Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation format #2244

Merged

Conversation

pascalheidmann
Copy link
Contributor

@pascalheidmann pascalheidmann commented Apr 2, 2023

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? yes
Fixed tickets #...

Starting with symfony/yaml:5.1, deprecations should contain both package and version and not just a message

@pascalheidmann pascalheidmann changed the title Fix depreaction format Fix deprecation format Apr 2, 2023
@dpfaffenbauer
Copy link
Member

@pascalheidmann this breaks the tests

@dpfaffenbauer dpfaffenbauer added the wrong-branch needs rebasing label Apr 7, 2023
@pascalheidmann pascalheidmann force-pushed the deprecated-deprecation-format branch from b99944e to 80831d9 Compare April 7, 2023 21:57
@pascalheidmann pascalheidmann changed the base branch from master to 3.0 April 7, 2023 21:57
@pascalheidmann pascalheidmann force-pushed the deprecated-deprecation-format branch from d8e6138 to 80831d9 Compare April 7, 2023 22:02
@dpfaffenbauer
Copy link
Member

@pascalheidmann rebase was fine, but tests are still broken

@pascalheidmann pascalheidmann force-pushed the deprecated-deprecation-format branch from 80831d9 to 2879a6d Compare April 9, 2023 23:19
@pascalheidmann
Copy link
Contributor Author

@dpfaffenbauer should now catched all broken instances... Regex can be hard sometimes

@dpfaffenbauer dpfaffenbauer merged commit ff1d171 into coreshop:3.0 Apr 10, 2023
@dpfaffenbauer
Copy link
Member

thanks mate @pascalheidmann 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wrong-branch needs rebasing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants