Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CoreExtensions] don't allow any diff until properly implemented #1050

Merged
merged 1 commit into from
Jul 18, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/CoreShop/Bundle/CoreBundle/CoreExtension/StorePrice.php
Original file line number Diff line number Diff line change
Expand Up @@ -534,7 +534,15 @@ public function getFromCsvImport($importValue, $object = null, $params = [])
*/
public function isDiffChangeAllowed($object, $params = [])
{
return true;
return false;
}

/**
* {@inheritDoc}
*/
public function getDiffDataForEditMode($data, $object = null, $params = [])
{
return [];
}

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,15 @@ public function getFromCsvImport($importValue, $object = null, $params = [])
*/
public function isDiffChangeAllowed($object, $params = [])
{
return true;
return false;
}

/**
* {@inheritDoc}
*/
public function getDiffDataForEditMode($data, $object = null, $params = [])
{
return [];
}

/**
Expand Down
9 changes: 8 additions & 1 deletion src/CoreShop/Bundle/MoneyBundle/CoreExtension/Money.php
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,14 @@ public function getFromCsvImport($importValue, $object = null, $params = [])
*/
public function isDiffChangeAllowed($object, $params = [])
{
return true;
return false;
}
/**
* {@inheritDoc}
*/
public function getDiffDataForEditMode($data, $object = null, $params = [])
{
return [];
}

/**
Expand Down
16 changes: 16 additions & 0 deletions src/CoreShop/Bundle/PimcoreBundle/CoreExtension/SerializedData.php
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,22 @@ class SerializedData extends Model\DataObject\ClassDefinition\Data implements Re
*/
public $phpdocType;

/**
* {@inheritdoc}
*/
public function isDiffChangeAllowed($object, $params = [])
{
return false;
}

/**
* {@inheritDoc}
*/
public function getDiffDataForEditMode($data, $object = null, $params = [])
{
return [];
}

/**
* {@inheritdoc}
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,22 @@ public function preSetData($object, $data, $params = [])
return $data;
}

/**
* {@inheritdoc}
*/
public function isDiffChangeAllowed($object, $params = [])
{
return false;
}

/**
* {@inheritDoc}
*/
public function getDiffDataForEditMode($data, $object = null, $params = [])
{
return [];
}

/**
* {@inheritdoc}
*/
Expand Down
16 changes: 16 additions & 0 deletions src/CoreShop/Bundle/ResourceBundle/CoreExtension/Multiselect.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,22 @@

abstract class Multiselect extends Model\DataObject\ClassDefinition\Data\Multiselect
{
/**
* {@inheritDoc}
*/
public function isDiffChangeAllowed($object, $params = [])
{
return false;
}

/**
* {@inheritDoc}
*/
public function getDiffDataForEditMode($data, $object = null, $params = [])
{
return [];
}

/**
* @param mixed $object
* @param array $params
Expand Down
16 changes: 16 additions & 0 deletions src/CoreShop/Bundle/ResourceBundle/CoreExtension/Select.php
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,22 @@ abstract protected function getRepository();
*/
abstract protected function getModel();

/**
* {@inheritDoc}
*/
public function isDiffChangeAllowed($object, $params = [])
{
return false;
}

/**
* {@inheritDoc}
*/
public function getDiffDataForEditMode($data, $object = null, $params = [])
{
return [];
}

/**
* @return string | array
*/
Expand Down