Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: publish images to ghcr.io as well #193

Merged
merged 2 commits into from
Jan 31, 2024

Conversation

theseion
Copy link
Contributor

No description provided.

@theseion theseion requested a review from fzipi January 29, 2024 12:11
@theseion theseion force-pushed the enable-ghcr.io branch 4 times, most recently from f75bd4b to d4bc758 Compare January 29, 2024 12:50
@fzipi
Copy link
Member

fzipi commented Jan 29, 2024

Hmmm... doesn't publish need to have a dependency on verify? From what I see here, images are going to be published just when it builds ok, but it doesn't mean they are working...

I would at least publish if images are verified...

@theseion
Copy link
Contributor Author

We could do that. The way it's set up at the moment though, the verification workflow would always run before the publishing workflow, because we merge from develop to master, and develop has already been verified because we merge PRs to develop.
On the other hand, I suppose it doesn't hurt to verify images before publishing one more time. I would, however, change the way it's done at the moment. Right now, as you say, verification runs in parallel with publishing. Even if we serialize those jobs, both workflows would currently run full builds because they don't run within the same context. I could try to refactor that into three jobs:

  • build: build all images and create tarball outputs for the following jobs
  • verify: verify images from the build job
  • publish: publish images from the build job

That looks beautiful but seems like a lot of work to me. My two cents: because we never push to master, I think we can simply refrain from running verification on the master branch (again).

@fzipi
Copy link
Member

fzipi commented Jan 30, 2024

Ok, makes sense. So do you want to merge this one?

@theseion theseion merged commit d430a1e into coreruleset:develop Jan 31, 2024
6 checks passed
@theseion theseion deleted the enable-ghcr.io branch January 31, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants