Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove unnecessary capture groups #3849

Merged
merged 5 commits into from
Oct 9, 2024
Merged

fix: remove unnecessary capture groups #3849

merged 5 commits into from
Oct 9, 2024

Conversation

TimDiam0nd
Copy link
Contributor

Remove capture groups that arent used in 934120 and 955110

fzipi
fzipi requested changes Oct 7, 2024
View reviewed changes
Copy link
Member

@fzipi fzipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice if you add a test for 955110 (using /reflect)

@TimDiam0nd TimDiam0nd mentioned this pull request Oct 8, 2024
Closed
@TimDiam0nd TimDiam0nd requested a review from fzipi October 8, 2024 16:42
@fzipi fzipi requested a review from theseion October 9, 2024 01:20
fzipi
fzipi approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@fzipi fzipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding tests! 💪

@fzipi fzipi dismissed theseion’s stale review October 9, 2024 01:21

Changes were applied.

@fzipi fzipi added this pull request to the merge queue Oct 9, 2024
Merged via the queue into coreruleset:main with commit 52217b6 Oct 9, 2024
5 checks passed
@TimDiam0nd TimDiam0nd deleted the patch-2 branch October 9, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzipi fzipi fzipi approved these changes

@theseion theseion Awaiting requested review from theseion

Assignees
No one assigned
Labels
release:fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TimDiam0nd @theseion @fzipi