-
Notifications
You must be signed in to change notification settings - Fork 29
Conversation
/cc @sdemos for review |
hmm that's odd, it looks like the api changed slightly. the string it's returning is from the |
actually it turns out that we are on rust 1.28 now (coreos/coreos-overlay#3378) so we should actually just bump the ci version and see if that fixes it |
Ah, I didn't see this locally as I have a 1.29 (where this is fine). I'll check tomorrow and see if I manage to make it work on 1.26 too. My guess is that it may be rust-lang/rust#51178, which is new in 1.29 anyway. |
alright, that makes sense. fwiw we will be bumping up to 1.29 at some point apparently per @dm0- (pending some eclass work), but it seems like the fix is probably as simple as changing it to |
The CL Rust 1.29 upgrade is coreos/portage-stable#688 which depends on coreos/portage-stable#690. Assuming 690 gets reviewed this week, it will be in the alpha next Tuesday. |
The dependency PR was merged, and I'm running one last test build on the Rust update. CL should be on 1.29 tomorrow. |
e111820
to
3985ad4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that works for me. everything looks good.
No description provided.