Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

livefs: add warning that /etc won't be preserved #986

Closed
wants to merge 1 commit into from
Closed

livefs: add warning that /etc won't be preserved #986

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/daemon/rpmostreed-transaction-livefs.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -659,6 +659,9 @@ livefs_transaction_execute_inner (LiveFsTransaction *self,
return FALSE;
}

/* XXX: right now we don't have a good solution for this */
rpmostree_output_message ("WARNING: changes to /etc are not currently preserved!");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more info? are not preserved in what situation?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the linked issue: #40. This is not unique to livefs, it just makes it more obvious.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm just saying that a little more info for the user in this situation wouldn't be bad. i.e. any changes made to /etc before reboot will not be preserved after reboot!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha. Tweaked in #988.


/* Write out the origin as having completed this */
if (!write_livefs_state (sysroot, booted_deployment, NULL, target_csum, error))
return FALSE;
Expand Down