Don't create ambiguous filesystems, and warn when reusing one #991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
kola tests are failing because we're not pulling |
This will be better once we do coreos/fedora-coreos-tracker#511. But until then instead of waiting for coreos/ignition-dracut#190 to get into an RPM, we can pretty easily just "build" ignition-dracut from scratch here. Something like (untested): diff --git a/.cci.jenkinsfile b/.cci.jenkinsfile
index 8b09b66..de332f6 100644
--- a/.cci.jenkinsfile
+++ b/.cci.jenkinsfile
@@ -15,7 +15,12 @@ cosaPod(buildroot: true) {
mkdir -p overrides/rpm && cd overrides/rpm
curl -L --remote-name-all https://kojipkgs.fedoraproject.org//packages/kernel/5.6.7/200.fc31/x86_64/kernel{,-core,-modules}-5.6.7-200.fc31.x86_64.rpm
""")
- fcosBuild(skipInit: true, make: true, skipKola: true)
+ shwrap("""
+ // and we want latest ignition-dracut until it's merged
+ // https://github.com/coreos/fedora-coreos-tracker/issues/511
+ git clone https://github.com/coreos/ignition-dracut
+ """)
+ fcosBuild(skipInit: true, make: true, makeDirs: ["ignition-dracut"], skipKola: true)
}
// we run the blackbox tests separately instead of as part of the main kola
|
jlebon
approved these changes
Jun 3, 2020
We need to test overwriting a ZFS filesystem with another filesystem, but we don't have access to a mkfs.zfs. Embed a small ZFS image and copy it to a partition when needed.
Needed when mounting ambivalent filesystems.
We still do three separate blkid probes, but returning a single struct presents a better high-level interface. The disks stage was already aggregating the three calls at a higher level.
When checking whether an existing filesystem matches the config, detect multiple filesystem signatures on a target partition. If found, log a warning. Don't do more than that for now, for backward compatibility and because it's not clear that we should reject an otherwise-matching filesystem just because it contains some leftover bits. Disallow multiple signatures during test output validation, unless the test requests otherwise.
|
Updated! |
Creating a filesystem doesn't necessarily remove all remnants of previous superblocks, notably if the old filesystem is ZFS. Run wipefs first, to prevent blkid from refusing to identify the resulting filesystem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ZFS has an unusual property: it has multiple superblocks distributed throughout the disk, and none of
mkfs.ext4,mkfs.xfs, ormkfs.vfatclobber all of them. Ifblkidorlsblkdiscover superblocks of both ZFS and one of those other filesystems, they won't report a filesystem type at all (blkidwill ignore the entire partition), andmountwill refuse to mount the filesystem without an explicit-targument.When creating a new filesystem, run
wipefson the partition to ensure we don't create an ambiguous (or, aslibblkidcalls it, "ambivalent") filesystem. When reusing an existing filesystem, log a warning if it is ambivalent, but otherwise proceed as before.Pursuant to coreos/fedora-coreos-tracker#500.