key: increase default RSA key size from 1024 to 2048 bits #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The reason I didn't do this already is because I haven't thought through the migration implications (if there are any). If that's all good (@bobbyrullo?) then LGTM. |
|
My (not very deep) thoughts about this - since this change only applies to new keys (and clients of those keys really shouldn't be making assumptions about their size) this change LGTM. I'd still love if @bobbyrullo weighed in, though. |
|
LGTM - sorry for taking so long to look at this |
bobbyrullo
added a commit
that referenced
this pull request
Dec 17, 2015
key: increase default RSA key size from 1024 to 2048 bits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per @gtank's recommendations, increase the default RSA key size in
GeneratePrivateKey from 1024 to 2048 bits.
Closes #15