test: added test scripts for the functional tests #1430

kayrus · 2016-02-11T16:24:10Z

subj

jonboulle · 2016-02-11T16:28:44Z

I don't understand the use case for this. can you help me understand what it provides over just a bash script that runs this? Since we still need etcd, systemd etc running on the host.

kayrus · 2016-02-11T16:59:13Z

It is still WIP. And this script will be executed on coreos.

tixxdz · 2016-02-12T10:11:17Z

You may also check if etcd is up.

jonboulle · 2016-02-12T10:16:58Z

What is the point of doing this in docker at all? Look how much stuff you necessarily need to bring in from the host..

kayrus · 2016-02-12T10:50:32Z

@jonboulle this will allow you to run tests directly on coreos. which already has etcd.

jonboulle · 2016-02-12T11:30:44Z

Why do you need docker for that? The functional tests run fine on coreos
without it

kayrus [email protected] schrieb am Fr., 12. Feb. 2016 11:50:

@jonboulle https://github.com/jonboulle this will allow you to run
tests directly on coreos. which already has etcd.

—
Reply to this email directly or view it on GitHub
#1430 (comment).

kayrus · 2016-02-12T11:34:32Z

@jonboulle there is no go binary inside coreos.

antrik · 2016-02-12T13:57:41Z

To elaborate a bit: according to functional/README.md, the official way to run tests is inside a CoreOS VM, typically through Vagrant. However, as CoreOS doesn't provide a Go environment itself, the README suggest mapping it from outside the VM using Vagrant shared folders. But that's neither easy nor a self-contained reproducible environment. In our understanding, the canonical way to get a Go environment inside CoreOS is by running a golang container.

jonboulle · 2016-02-16T12:42:00Z

@antrik thanks for the context, very helpful. I discussed out of band with @mirkoboehm and we'll circulate notes shortly

kayrus · 2016-02-18T17:26:28Z

@jonboulle tests passed. should we squash and merge?

jonboulle · 2016-02-19T10:26:20Z

functional/platform/nspawn.go

@@ -302,14 +302,18 @@ func (nc *nspawnCluster) createMember(id string) (m Member, err error) {

 		// minimum requirements for running systemd/coreos in a container
 		fmt.Sprintf("mkdir -p %s/usr", fsdir),
+		//fmt.Sprintf("mkdir -p %s/lib", fsdir), //ubuntu


can you explain all these?

I tried to run these tests in ubuntu without cloud-config. Decided to keep this. If you don't like - i'll remove.

We definitely shouldn't leave commented lines in here. Are the lines totally superfluous now? The tests all work fine without?

Yes, they do. Will remove ubuntu stuff. But will keep .. 500 ... for future support.

jonboulle · 2016-02-19T11:40:46Z

build

@@ -1,29 +1,31 @@
 #!/bin/bash -e

+CDIR=$(cd `dirname $0` && pwd)


is this working around some problem you encountered?

Yes, when you run scripts from home directory for example. cd ~ ; ./fleet/build

jonboulle · 2016-02-19T13:30:38Z

functional/README.md

+Then run the functional tests:
+
+```sh
+$ git clone https://github.com/coreos/fleet


haven't we already cloned?

tixxdz · 2016-02-19T15:05:31Z

functional/test

+  eval $(ssh-agent)
+fi
+
+chmod 600 functional/fixtures/id_rsa


Please document why we need this one.

jonboulle · 2016-02-22T14:10:15Z

For the sake of moving forward:
i) squash commit history into something sensible
ii) merge this
iii) please follow up the comments I've just added

test: added test scripts for the functional tests

kayrus changed the title ~~test: added test-docker script for functional tests~~ [WIP] test: added test-docker script for functional tests Feb 11, 2016

kayrus force-pushed the kayrus/docker_test branch from 5a8b858 to 27b9686 Compare February 11, 2016 18:02

kayrus changed the title ~~[WIP] test: added test-docker script for functional tests~~ [WIP] test: added test scripts for the functional tests Feb 12, 2016

kayrus mentioned this pull request Feb 15, 2016

tests: set up functional tests on CI #1403

Closed

kayrus force-pushed the kayrus/docker_test branch 6 times, most recently from 2d4ba84 to b67bfb8 Compare February 17, 2016 16:33

kayrus mentioned this pull request Feb 18, 2016

CoreOS 955.0.0: sometimes cloud-config is not loaded in iPXE-boot coreos/bugs#1120

Closed

kayrus force-pushed the kayrus/docker_test branch from ce6756c to 9f9078f Compare February 18, 2016 16:20

kayrus force-pushed the kayrus/docker_test branch 2 times, most recently from 83c56da to 112c46d Compare February 19, 2016 10:07

jonboulle reviewed Feb 19, 2016
View reviewed changes

reneengelhard mentioned this pull request Feb 19, 2016

github.com/coreos/fleet/agent unit test fail with one cpu #1434

Closed

jonboulle reviewed Feb 19, 2016
View reviewed changes

kayrus force-pushed the kayrus/docker_test branch from 97daef8 to 79a60c7 Compare February 19, 2016 14:29

tixxdz reviewed Feb 19, 2016
View reviewed changes

test: added scripts for functional tests

180b7e7

kayrus force-pushed the kayrus/docker_test branch from 7ece6d7 to 180b7e7 Compare February 24, 2016 14:49

kayrus added a commit that referenced this pull request Feb 24, 2016

Merge pull request #1430 from endocode/kayrus/docker_test

8d7930c

test: added test scripts for the functional tests

kayrus merged commit 8d7930c into coreos:master Feb 24, 2016

kayrus deleted the kayrus/docker_test branch March 30, 2016 07:47

kayrus changed the title ~~[WIP] test: added test scripts for the functional tests~~ test: added test scripts for the functional tests Jun 13, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: added test scripts for the functional tests #1430

test: added test scripts for the functional tests #1430

kayrus commented Feb 11, 2016

jonboulle commented Feb 11, 2016

kayrus commented Feb 11, 2016

tixxdz commented Feb 12, 2016

jonboulle commented Feb 12, 2016

kayrus commented Feb 12, 2016

jonboulle commented Feb 12, 2016

kayrus commented Feb 12, 2016

antrik commented Feb 12, 2016

jonboulle commented Feb 16, 2016

kayrus commented Feb 18, 2016

jonboulle Feb 19, 2016

kayrus Feb 19, 2016

jonboulle Feb 19, 2016

kayrus Feb 19, 2016

jonboulle Feb 19, 2016

kayrus Feb 19, 2016

jonboulle Feb 19, 2016

tixxdz Feb 19, 2016

kayrus Feb 19, 2016

jonboulle commented Feb 22, 2016

		@@ -1,29 +1,31 @@
		#!/bin/bash -e

		CDIR=$(cd `dirname $0` && pwd)

test: added test scripts for the functional tests #1430

test: added test scripts for the functional tests #1430

Conversation

kayrus commented Feb 11, 2016

jonboulle commented Feb 11, 2016

kayrus commented Feb 11, 2016

tixxdz commented Feb 12, 2016

jonboulle commented Feb 12, 2016

kayrus commented Feb 12, 2016

jonboulle commented Feb 12, 2016

kayrus commented Feb 12, 2016

antrik commented Feb 12, 2016

jonboulle commented Feb 16, 2016

kayrus commented Feb 18, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jonboulle commented Feb 22, 2016