Add flag to override tokenLimit #1265
Conversation
|
@miekg I'm on board with this change, but It would be cleaner to pass token limit through NewServeMux and hand it to the paginated resources directly rather than pulling it out of a package-level variable. |
|
[ Quoting [email protected] in "Re: [fleet] Add flag to override to..." ]
Ack and ack. I hoping I have some time tomorrow to work on this. /Miek Miek Gieben |
|
Friendly ping @bcwaldon |
|
@mischief, can you please take at this PR reducing the size of tokenLimits. We use Fleet API from our services and the current 100 limit causes excessive load on etcd (each page is an etcd re-query). |
|
LGTM |
|
@wuqixuan can you merge? Thanks. |
| @@ -75,6 +75,7 @@ func main() { | |||
| cfgset.String("public_ip", "", "IP address that fleet machine should publish") | |||
| cfgset.String("metadata", "", "List of key-value metadata to assign to the fleet machine") | |||
| cfgset.String("agent_ttl", agent.DefaultTTL, "TTL in seconds of fleet machine state in etcd") | |||
| cfgset.Int("token_limit", 100, "Limit amount of entries per page returned") | |||
There was a problem hiding this comment.
"Maximum number of entries per page returned from API requests"
There was a problem hiding this comment.
Yes, the new statement is better.
|
@miekg , I have no permission to merge currently. Need @jonboulle @mischief help. |
|
Ack, and I made that little change. |
|
@miekg could you please rebase + squash your commits into a single one (perhaps with the commit message from https://github.com/miekg/fleet/commit/3d3421d8b1f0080f41869988f18dc6a49b37a45a), then I will merge. thanks! |
Add the tokenLimit to the NewServeMux and plumb it through the handlers. Also add a flag to fleet.conf (token_limit) to override the built-in token limit of 100.
|
done. |
Add flag to override tokenLimit
Make tokenLimit in api public and add a flag to fleet.conf (token_limit)
to override the built-in token limit of 100.
Note: this PR is rather hackish, it would be nice to know if something like will be considered for merging (if cleaned up, etc .etc.). IOW: comments welcome!