Skip to content
This repository has been archived by the owner on Jan 30, 2020. It is now read-only.

usability: show warning for the fleetctl subcommands #1443

Closed
kayrus opened this issue Feb 26, 2016 · 5 comments
Closed

usability: show warning for the fleetctl subcommands #1443

kayrus opened this issue Feb 26, 2016 · 5 comments
Labels
low hanging fruit
Milestone
v0.13.0

Comments

@kayrus
Copy link
Contributor

kayrus commented Feb 26, 2016

Current behavior:

$ fleetctl destroy # start/stop/load/any fleet subcommand
# nothing is here
$ echo $?
0

Desired behavior:

$ fleetctl destroy # start/stop/load/any fleet subcommand
Too few arguments.
$ echo $?
1
@kayrus
Copy link
Contributor Author

kayrus commented Feb 29, 2016

relates #1445

@kayrus kayrus changed the title user experience: show warning for the fleetctl subcommands usability: show warning for the fleetctl subcommands Feb 29, 2016
@tixxdz
Copy link
Contributor

tixxdz commented Feb 29, 2016

running: fleetctl journal
One unit file must be provided.

We should just be consistent and of course tell the user that he must supply the right arguments.

@jonboulle
Copy link
Contributor

Following previous discussions about the semantics of fleetctl destroy <nonexistent unit>, and for example #1417, it's not immediately obvious to me that fleetctl destroy should error. We need to justify making a backwards-incompatible change here

@jonboulle jonboulle added this to the v0.13.0 milestone Mar 1, 2016
@jonboulle
Copy link
Contributor

How about we just write something to stderr saying "No units given"

@kayrus
Copy link
Contributor Author

kayrus commented Mar 1, 2016

and 0 exit code? ok for me.

dongsupark pushed a commit to endocode/fleet that referenced this issue Mar 3, 2016
fleetctl: check for empty input unit strings
44272de 
If no unit name is given for fleetctl commands like destroy, load,
start, stop, submit, and unload, then return with exit code 0,
printing out a soft warning message to stderr.

Fixes: coreos#1443
@dongsupark dongsupark mentioned this issue Mar 3, 2016
Closed
dongsupark pushed a commit to endocode/fleet that referenced this issue Mar 4, 2016
fleetctl: check for empty input unit strings
92f287a 
If no unit name is given for fleetctl commands like destroy, load,
start, stop, submit, and unload, then return with exit code 0,
printing out a soft warning message to stderr.

Fixes: coreos#1443
dongsupark pushed a commit to endocode/fleet that referenced this issue Mar 4, 2016
fleetctl: check for empty input unit strings
a2d16c6 
If no unit name is given for fleetctl commands like destroy, load,
start, stop, submit, and unload, then return with exit code 0,
printing out a soft warning message to stderr.

Fixes: coreos#1443
dongsupark pushed a commit to endocode/fleet that referenced this issue Mar 7, 2016
fleetctl: check for empty input unit strings
e6e8499 
If no unit name is given for fleetctl commands like destroy, load,
start, stop, submit, and unload, then return with exit code 0,
printing out a soft warning message to stderr.

Fixes: coreos#1443
@dongsupark dongsupark mentioned this issue Mar 7, 2016
Merged
dongsupark pushed a commit to endocode/fleet that referenced this issue Mar 9, 2016
fleetctl: check for empty input unit strings
dec2dd5 
If no unit name is given for fleetctl commands like destroy, load,
start, stop, submit, and unload, then return with exit code 0,
printing out a soft warning message to stderr.

Fixes: coreos#1443
dongsupark pushed a commit to endocode/fleet that referenced this issue Mar 10, 2016
fleetctl: check for empty input unit strings
80d37bb 
If no unit name is given for fleetctl commands like destroy, load,
start, stop, submit, and unload, then return with exit code 0,
printing out a soft warning message to stderr.

Fixes: coreos#1443
kayrus pushed a commit to endocode/fleet that referenced this issue Mar 31, 2016
@kayrus
fleetctl: check for empty input unit strings
fb1bb84 
If no unit name is given for fleetctl commands like destroy, load,
start, stop, submit, and unload, then return with exit code 0,
printing out a soft warning message to stderr.

Fixes: coreos#1443
kayrus pushed a commit to endocode/fleet that referenced this issue Mar 31, 2016
@kayrus
fleetctl: check for empty input unit strings
705044d 
If no unit name is given for fleetctl commands like destroy, load,
start, stop, submit, and unload, then return with exit code 0,
printing out a soft warning message to stderr.

Fixes: coreos#1443
hectorj2f pushed a commit to giantswarm/fleet that referenced this issue Apr 6, 2016
@hectorj2f
fleetctl: check for empty input unit strings
437a586 
If no unit name is given for fleetctl commands like destroy, load,
start, stop, submit, and unload, then return with exit code 0,
printing out a soft warning message to stderr.

Fixes: coreos#1443
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
low hanging fruit
Projects
None yet
Milestone
v0.13.0
Development

No branches or pull requests
3 participants
@tixxdz @jonboulle @kayrus