design doc: add design doc #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dustymabe
reviewed
Aug 22, 2018
Design.md
Outdated
|
|
||
| ## Disk Layout | ||
|
|
||
| Originally discussed in issue #18 |
There was a problem hiding this comment.
would be nice if this was a hyperlink to #18 - when I view it rendered it doesn't seem to auto hyperlink
There was a problem hiding this comment.
sure, I thought it would autolink, but I guess not?
ajeddeloh
force-pushed
the
add-design-doc
branch
from
0042103 to
5944498
Compare
dustymabe
reviewed
Aug 22, 2018
Design.md
Outdated
| may not work with poorly implemeted UEFIs. | ||
| - What is the exact partition layout? | ||
| - Do we make /etc a ro bind mount? | ||
| - Do filesystem do we use for / and /var? ext4? |
ajeddeloh
force-pushed
the
add-design-doc
branch
2 times, most recently
from
b16008f to
337927d
Compare
|
LGTM |
|
anybody else want to review ? |
|
I'll give it a day and merge tomorrow unless someone else has other comments. SG? We should probably decide how we decide merge-readiness for these. |
bgilbert
approved these changes
Aug 23, 2018
Add a document to record conclusions from dicsussions in the issues section.
ajeddeloh
force-pushed
the
add-design-doc
branch
from
337927d to
81ad941
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accidently
git push -dinstead ofgit push -fon the other PR, which made it unopenable.Please check for:
I only did the partitioning issue. We can add summaries of other closed issues in more PRs.
I envision that when we want to close out an issue, we PR this doc with a summary. Once we agree the PR is good and accurately encapsulates the discussion, we merge the PR and close the issue.
As the doc grows we may want to break it out into multiple docs in a directory, but that can come later.
Finally, I'd prefer to keep this doc about design of FCOS itself and not about the process around it. We can have a seperate doc for that (the README does a great job right now) if we want.