-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create fedora-coreos-tools or so #235
Comments
And we wanted |
I still don't see the advantage of having everything share a binary name. I find those kind of tools more confusing that just individual programs. In general I think we should be striving towards a "box of tools" rather than one integrated tool. What would be the difference between virt-install and run? I'm not sure the utility in providing those. Users can already run qemu/virt-install/kola run individually and I don't see benefit in abstracting over those. I think it will just make it harder to tell what's going on under the hood (especially with virt-install where we would running qemu via virt-install via whatever top level wrapper we have). |
Two reasons: Discoverability, and in Unix,
Right, the philosophical division here is also clearly visible in
We don't want users running kola, right? As far as running qemu directly; yes you've documented that but I find it way more convenient to Are you disagreeing with the premise that we want to ship a |
See some extra comments in #246 TL;DNR: This proposed set of install instructions is based on the fedora install page. There is an implied "coreos-common" package dependency behind each these. Quick start:
This installs coreos-virt and starts a VM cluster on your machine with default settings, ready to experiment. Other packages:
Once installed see /usr/share/doc/coreos-/README.md. |
We had a realtime chat about this issue that ranged over various topics. I forget all of it, but one bit I do remember about the "subcommands vs standalone" discussion is that the "subcommand pattern" feels most natural when the primary command is operating on an explicit "context".
In order for a hypothetical So I am leaning more towards standalone tools but...the problem is what to call them. |
@alanconway An explicit goal of this issue was to support packaging the tools for other distributions e.g. Ubuntu as well as potentially MacOS and Windows bash shell. So I don't think we should focus too much on the package names or |
@cgwalters I think #246 isn't exactly the same issue after all, but it overlaps. I'll re-open and re-focus it on a better user experience for https://getfedora.org/en/coreos/download/ That issue could be addressed by packaging the existing download instructions, but clearly it should take account of tools and packages that emerge from this issue, so we end up with a sane set of coreos- related packages. |
As the new comment says: Yes, this is a hack that loses sane auditing around what git commit we used to build fcct, etc. In the future we'll probably give in and package it or something, see also coreos/fedora-coreos-tracker#235 But for now I want to have it in cosa by default so we can use it; see also coreos#670
As the new comment says: Yes, this is a hack that loses sane auditing around what git commit we used to build fcct, etc. In the future we'll probably give in and package it or something, see also coreos/fedora-coreos-tracker#235 But for now I want to have it in cosa by default so we can use it; see also coreos#670
As the new comment says: Yes, this is a hack that loses sane auditing around what git commit we used to build fcct, etc. In the future we'll probably give in and package it or something, see also coreos/fedora-coreos-tracker#235 But for now I want to have it in cosa by default so we can use it; see also #670
I built a tool in this space to help my own development workflow out. I'll leave it here for reference https://github.com/nsmith5/fcosctl. I don't know that Everything you need to develop Go is in the |
There's a lot of cool things `cosa run` can do. Let's add some example invocations to make it easier for newcomers to wield it. (Strongly related is coreos/fedora-coreos-tracker#235 to extract it to a lighter more dedicated container.)
There's a lot of cool things `cosa run` can do. Let's add some example invocations to make it easier for newcomers to wield it. (Strongly related is coreos/fedora-coreos-tracker#235 to extract it to a lighter more dedicated container.)
Splitting this out from coreos/coreos-assembler#670 (comment)
Scope of this is "things people using any distribution may want to run to target FCOS". Additionally it would be included in coreos-assembler. So far:
If we don't have
fcostool
, then what would "cosa run" be called? Or I guess we could still havefcostool
, and you just wantfcct
to be special enough to stand on its own? So it'd be:fcct
(andfcostool ct
?)fcostool run
fcostool virt-install
Anything else? Maybe something to download images?
The text was updated successfully, but these errors were encountered: