Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Package Request: bash-color-prompt #1567

Closed
travier opened this issue Sep 6, 2023 · 5 comments · Fixed by coreos/fedora-coreos-config#2634
Closed

New Package Request: bash-color-prompt #1567

travier opened this issue Sep 6, 2023 · 5 comments · Fixed by coreos/fedora-coreos-config#2634
Assignees

Comments

@travier
Copy link
Member

travier commented Sep 6, 2023

What, if any, are the additional dependencies on the package? (i.e. does it pull in Python, Perl, etc)

[core@cosa-devsh ~]$ sudo rpm-ostree install --dry-run bash-color-prompt
Checking out tree 3668815... done
Enabled rpm-md repositories: fedora-cisco-openh264 fedora-modular updates-modular updates fedora updates-archive
Updating metadata for 'fedora-cisco-openh264'... done
Updating metadata for 'fedora-modular'... done
Updating metadata for 'updates-modular'... done
Updating metadata for 'updates'... done
Updating metadata for 'fedora'... done
Updating metadata for 'updates-archive'... done
Importing rpm-md... done
rpm-md repo 'fedora-cisco-openh264'; generated: 2023-03-14T10:56:46Z solvables: 4
rpm-md repo 'fedora-modular'; generated: 2023-04-13T20:30:47Z solvables: 1082
rpm-md repo 'updates-modular'; generated: 2023-08-19T01:34:25Z solvables: 1086
rpm-md repo 'updates'; generated: 2023-09-06T01:11:10Z solvables: 22993
rpm-md repo 'fedora'; generated: 2023-04-13T20:37:10Z solvables: 69222
rpm-md repo 'updates-archive'; generated: 2023-09-05T01:01:28Z solvables: 34479
Resolving dependencies... done
Installing 1 packages:
  bash-color-prompt-0.1-6.fc38.noarch (updates)
Exiting because of '--dry-run' option

What is the size of the package and its dependencies?

$ rpm -qip bash-color-prompt-0.1-6.fc38.noarch.rpm
Name        : bash-color-prompt
Version     : 0.1
Release     : 6.fc38
Architecture: noarch
Install Date: (not installed)
Group       : Unspecified
Size        : 19488
License     : GPL-2.0-or-later
Signature   : RSA/SHA256, Mon 21 Aug 2023 06:33:44 PM CEST, Key ID 809a8d7ceb10b464
Source RPM  : shell-color-prompt-0.1-6.fc38.src.rpm
Build Date  : Mon 21 Aug 2023 06:16:28 PM CEST
Build Host  : buildvm-s390x-26.s390.fedoraproject.org
Packager    : Fedora Project
Vendor      : Fedora Project
URL         : https://src.fedoraproject.org/rpms/shell-color-prompt
Bug URL     : https://bugz.fedoraproject.org/shell-color-prompt
Summary     : Color prompt for bash shell
Description :
Default colored bash prompt.

What problem are you trying to solve with this package? Or what functionality does the package provide?

We're following the upstream Fedora change: https://fedoraproject.org/wiki/Changes/Color_Bash_Prompt

Can the software provided by the package be run from a container? Explain why or why not.

No as it's for the shell for the host

Can the tool(s) provided by the package be helpful in debugging container runtime issues?

No

Can the tool(s) provided by the package be helpful in debugging networking issues?

No

Is it possible to layer the package onto the base OS as a day 2 operation? Explain why or why not.

Yes

In the case of packages providing services and binaries, can the packaging be adjusted to just deliver binaries?

Only a config file

Can the tool(s) provided by the package be used to do things we’d rather users not be able to do in FCOS?

No

Does the software provided by the package have a history of CVEs?

No

@cgwalters
Copy link
Member

OK by me 👍 - not worth deviating from any other Fedora editions.

@dustymabe
Copy link
Member

FWIW In the community meeting today we discussed this and it was generally agreed that we'd pick up this change.

@yasminvalim yasminvalim self-assigned this Sep 13, 2023
prestist added a commit to prestist/fedora-coreos-config that referenced this issue Sep 26, 2023
prestist added a commit to prestist/fedora-coreos-config that referenced this issue Sep 26, 2023
prestist added a commit to prestist/fedora-coreos-config that referenced this issue Sep 26, 2023
prestist added a commit to coreos/fedora-coreos-config that referenced this issue Sep 26, 2023
@dustymabe dustymabe added the status/pending-next-release Fixed upstream. Waiting on a next release. label Sep 26, 2023
coreosbot-releng pushed a commit to coreosbot-releng/os that referenced this issue Sep 27, 2023
Aashish Radhakrishnan (2):
      denylist: snooze ext.config.docker.basic on rawhide
      denylist: drop ext.config.kdump.crash test

Steven Presti (1):
      manifest: add bash-color-prompt for >= f39 fixes coreos/fedora-coreos-tracker#1567

Timothée Ravier (1):
      tests/kola/docker: Add a basic docker run test

gursewak1997 (2):
      upgrade/extended: Get latest release from update server This test fails when it is run during the time period between the stream build and the release. Updated the test to get the last_release from update server and check if there's an edge pointing to it.
      upgrade/extended: Fix last_release_index extraction method Initially, I was getting the last_release_index from the update json file itself under key org.fedoraproject.coreos.releases.age_index whereas we are using the actual index value of the versions as edge values in edges array
coreosbot-releng pushed a commit to coreosbot-releng/os that referenced this issue Sep 28, 2023
Aashish Radhakrishnan (2):
      denylist: snooze ext.config.docker.basic on rawhide
      denylist: drop ext.config.kdump.crash test

Steven Presti (1):
      manifest: add bash-color-prompt for >= f39 fixes coreos/fedora-coreos-tracker#1567

Timothée Ravier (1):
      tests/kola/docker: Add a basic docker run test

gursewak1997 (3):
      upgrade/extended: Get latest release from update server This test fails when it is run during the time period between the stream build and the release. Updated the test to get the last_release from update server and check if there's an edge pointing to it.
      upgrade/extended: Fix last_release_index extraction method Initially, I was getting the last_release_index from the update json file itself under key org.fedoraproject.coreos.releases.age_index whereas we are using the actual index value of the versions as edge values in edges array
      denylist: extend snooze for coreos.ignition.ssh.key
coreosbot-releng pushed a commit to coreosbot-releng/os that referenced this issue Sep 29, 2023
Aashish Radhakrishnan (2):
      denylist: snooze ext.config.docker.basic on rawhide
      denylist: drop ext.config.kdump.crash test

Steven Presti (1):
      manifest: add bash-color-prompt for >= f39 fixes coreos/fedora-coreos-tracker#1567

Timothée Ravier (1):
      tests/kola/docker: Add a basic docker run test

gursewak1997 (4):
      upgrade/extended: Get latest release from update server This test fails when it is run during the time period between the stream build and the release. Updated the test to get the last_release from update server and check if there's an edge pointing to it.
      upgrade/extended: Fix last_release_index extraction method Initially, I was getting the last_release_index from the update json file itself under key org.fedoraproject.coreos.releases.age_index whereas we are using the actual index value of the versions as edge values in edges array
      denylist: extend snooze for coreos.ignition.ssh.key
      denylist: bump snooze for ext.config.kdump.crash on aarch64 This test is still failing.
coreosbot-releng pushed a commit to coreosbot-releng/os that referenced this issue Sep 29, 2023
Aashish Radhakrishnan (2):
      denylist: snooze ext.config.docker.basic on rawhide
      denylist: drop ext.config.kdump.crash test

Jonathan Lebon (1):
      05core/dracut: enable `iscsi` module

Steven Presti (1):
      manifest: add bash-color-prompt for >= f39 fixes coreos/fedora-coreos-tracker#1567

Timothée Ravier (2):
      tests/kola/docker: Add a basic docker run test
      ci & tests: Switch to quay.io/fedora/fedora

gursewak1997 (4):
      upgrade/extended: Get latest release from update server This test fails when it is run during the time period between the stream build and the release. Updated the test to get the last_release from update server and check if there's an edge pointing to it.
      upgrade/extended: Fix last_release_index extraction method Initially, I was getting the last_release_index from the update json file itself under key org.fedoraproject.coreos.releases.age_index whereas we are using the actual index value of the versions as edge values in edges array
      denylist: extend snooze for coreos.ignition.ssh.key
      denylist: bump snooze for ext.config.kdump.crash on aarch64 This test is still failing.
coreosbot-releng pushed a commit to coreosbot-releng/os that referenced this issue Sep 30, 2023
Aashish Radhakrishnan (2):
      denylist: snooze ext.config.docker.basic on rawhide
      denylist: drop ext.config.kdump.crash test

Jonathan Lebon (2):
      05core/dracut: enable `iscsi` module
      kola/expected-contents: only check for `iscsi_ibft` on supported arches

Steven Presti (1):
      manifest: add bash-color-prompt for >= f39 fixes coreos/fedora-coreos-tracker#1567

Timothée Ravier (2):
      tests/kola/docker: Add a basic docker run test
      ci & tests: Switch to quay.io/fedora/fedora

gursewak1997 (5):
      upgrade/extended: Get latest release from update server This test fails when it is run during the time period between the stream build and the release. Updated the test to get the last_release from update server and check if there's an edge pointing to it.
      upgrade/extended: Fix last_release_index extraction method Initially, I was getting the last_release_index from the update json file itself under key org.fedoraproject.coreos.releases.age_index whereas we are using the actual index value of the versions as edge values in edges array
      denylist: extend snooze for coreos.ignition.ssh.key
      denylist: bump snooze for ext.config.kdump.crash on aarch64 This test is still failing.
      denylist: snooze kdump.crash for ppc64le in rawhide
coreosbot-releng pushed a commit to coreosbot-releng/os that referenced this issue Oct 3, 2023
Aashish Radhakrishnan (2):
      denylist: snooze ext.config.docker.basic on rawhide
      denylist: drop ext.config.kdump.crash test

Jonathan Lebon (2):
      05core/dracut: enable `iscsi` module
      kola/expected-contents: only check for `iscsi_ibft` on supported arches

Steven Presti (1):
      manifest: add bash-color-prompt for >= f39 fixes coreos/fedora-coreos-tracker#1567

Timothée Ravier (2):
      tests/kola/docker: Add a basic docker run test
      ci & tests: Switch to quay.io/fedora/fedora

gursewak1997 (5):
      upgrade/extended: Get latest release from update server This test fails when it is run during the time period between the stream build and the release. Updated the test to get the last_release from update server and check if there's an edge pointing to it.
      upgrade/extended: Fix last_release_index extraction method Initially, I was getting the last_release_index from the update json file itself under key org.fedoraproject.coreos.releases.age_index whereas we are using the actual index value of the versions as edge values in edges array
      denylist: extend snooze for coreos.ignition.ssh.key
      denylist: bump snooze for ext.config.kdump.crash on aarch64 This test is still failing.
      denylist: snooze kdump.crash for ppc64le in rawhide
coreosbot-releng pushed a commit to coreosbot-releng/os that referenced this issue Oct 5, 2023
Aashish Radhakrishnan (2):
      denylist: snooze ext.config.docker.basic on rawhide
      denylist: drop ext.config.kdump.crash test

Jonathan Lebon (3):
      05core/dracut: enable `iscsi` module
      kola/expected-contents: only check for `iscsi_ibft` on supported arches
      manifests: add crun-wasm.yaml

Michael Armijo (1):
      overrides: fast-track glibc-2.37-10.fc38

Steven Presti (1):
      manifest: add bash-color-prompt for >= f39 fixes coreos/fedora-coreos-tracker#1567

Timothée Ravier (2):
      tests/kola/docker: Add a basic docker run test
      ci & tests: Switch to quay.io/fedora/fedora

gursewak1997 (5):
      upgrade/extended: Get latest release from update server This test fails when it is run during the time period between the stream build and the release. Updated the test to get the last_release from update server and check if there's an edge pointing to it.
      upgrade/extended: Fix last_release_index extraction method Initially, I was getting the last_release_index from the update json file itself under key org.fedoraproject.coreos.releases.age_index whereas we are using the actual index value of the versions as edge values in edges array
      denylist: extend snooze for coreos.ignition.ssh.key
      denylist: bump snooze for ext.config.kdump.crash on aarch64 This test is still failing.
      denylist: snooze kdump.crash for ppc64le in rawhide
coreosbot-releng pushed a commit to coreosbot-releng/os that referenced this issue Oct 5, 2023
Aashish Radhakrishnan (2):
      denylist: snooze ext.config.docker.basic on rawhide
      denylist: drop ext.config.kdump.crash test

Jonathan Lebon (4):
      05core/dracut: enable `iscsi` module
      kola/expected-contents: only check for `iscsi_ibft` on supported arches
      manifests: add crun-wasm.yaml
      Revert "coreos-teardown-initramfs: use NetworkManager to teardown networking"

Michael Armijo (1):
      overrides: fast-track glibc-2.37-10.fc38

Steven Presti (1):
      manifest: add bash-color-prompt for >= f39 fixes coreos/fedora-coreos-tracker#1567

Timothée Ravier (3):
      tests/kola/docker: Add a basic docker run test
      ci & tests: Switch to quay.io/fedora/fedora
      tests/kola/docker/basic: Only run on FCOS

gursewak1997 (5):
      upgrade/extended: Get latest release from update server This test fails when it is run during the time period between the stream build and the release. Updated the test to get the last_release from update server and check if there's an edge pointing to it.
      upgrade/extended: Fix last_release_index extraction method Initially, I was getting the last_release_index from the update json file itself under key org.fedoraproject.coreos.releases.age_index whereas we are using the actual index value of the versions as edge values in edges array
      denylist: extend snooze for coreos.ignition.ssh.key
      denylist: bump snooze for ext.config.kdump.crash on aarch64 This test is still failing.
      denylist: snooze kdump.crash for ppc64le in rawhide
@dustymabe
Copy link
Member

The fix for this went into next stream release 39.20231002.1.1. Please try out the new release and report issues.

@dustymabe dustymabe added status/pending-testing-release Fixed upstream. Waiting on a testing release. and removed status/pending-next-release Fixed upstream. Waiting on a next release. labels Oct 5, 2023
HuijingHei pushed a commit to HuijingHei/fedora-coreos-config that referenced this issue Oct 10, 2023
HuijingHei pushed a commit to HuijingHei/fedora-coreos-config that referenced this issue Oct 10, 2023
@dustymabe
Copy link
Member

The fix for this went into testing stream release 39.20231101.2.0. Please try out the new release and report issues.

@dustymabe dustymabe added the status/pending-stable-release Fixed upstream and in testing. Waiting on stable release. label Nov 7, 2023
@dustymabe dustymabe removed the status/pending-testing-release Fixed upstream. Waiting on a testing release. label Nov 7, 2023
@dustymabe
Copy link
Member

The fix for this went into stable stream release 39.20231101.3.0.

@dustymabe dustymabe removed the status/pending-stable-release Fixed upstream and in testing. Waiting on stable release. label Nov 21, 2023
aaradhak pushed a commit to aaradhak/fedora-coreos-config that referenced this issue Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants