scripts: add versionary.py to drive FCOS versioning #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marking as draft for now since the strategy used for the Y component is still being discussed. @bgilbert had a proposal of instead making the timestamp an explicit separate file instead which sits alongside the lockfile. |
jlebon
added a commit
to jlebon/fedora-coreos-pipeline
that referenced
this pull request
Oct 22, 2019
This uses the new `versionary.py` script which implements the new versioning scheme: coreos/fedora-coreos-releng-automation#50
This seems like the option with the least "magic". |
|
Hmm, we could also just make rpm-ostree inject a I'd like to avoid two separate files that can go out of sync if possible. |
|
@bgilbert Thoughts on #50 (comment) ? |
|
Works for me. |
jlebon
added a commit
to jlebon/rpm-ostree
that referenced
this pull request
Nov 11, 2019
E.g. the generation timestamp, repos that were enabled, and their generation timestamps. This is just generally useful, though specifically the `metadata.generated` timestamp I'd like to make use in FCOS to drive versioning: coreos/fedora-coreos-releng-automation#50
jlebon
added a commit
to jlebon/rpm-ostree
that referenced
this pull request
Nov 11, 2019
E.g. the generation timestamp, repos that were enabled, and their generation timestamps. This is just generally useful, though I'd like to make use specifically of the new `metadata.generated` key in FCOS to drive versioning: coreos/fedora-coreos-releng-automation#50
jlebon
force-pushed
the
pr/versionary
branch
from
c932c34 to
5785b74
Compare
|
OK, reworked this! Now requires coreos/rpm-ostree#1938. |
openshift-merge-robot
pushed a commit
to coreos/rpm-ostree
that referenced
this pull request
Nov 12, 2019
E.g. the generation timestamp, repos that were enabled, and their generation timestamps. This is just generally useful, though I'd like to make use specifically of the new `metadata.generated` key in FCOS to drive versioning: coreos/fedora-coreos-releng-automation#50
jlebon
force-pushed
the
pr/versionary
branch
from
5785b74 to
ffdddcc
Compare
|
OK, this is ready to go! |
jlebon
added a commit
to jlebon/fedora-coreos-pipeline
that referenced
this pull request
Dec 11, 2019
This uses the new `versionary.py` script which implements the new versioning scheme: coreos/fedora-coreos-releng-automation#50
jlebon
added a commit
to jlebon/fedora-coreos-pipeline
that referenced
this pull request
Dec 11, 2019
This uses the new `versionary.py` script which implements the new versioning scheme: coreos/fedora-coreos-releng-automation#50
jlebon
force-pushed
the
pr/versionary
branch
from
ffdddcc to
46de753
Compare
This script implements the versioning scheme as described in: coreos/fedora-coreos-tracker#211 The next step is to use this in the FCOS pipeline to drive versioning.
jlebon
force-pushed
the
pr/versionary
branch
from
46de753 to
d7162c6
Compare
jlebon
added a commit
to jlebon/fedora-coreos-pipeline
that referenced
this pull request
Dec 17, 2019
This uses the new `versionary.py` script which implements the new versioning scheme: coreos/fedora-coreos-releng-automation#50
|
Thanks for the review! |
jlebon
added a commit
to jlebon/fedora-coreos-pipeline
that referenced
this pull request
Dec 17, 2019
This uses the new `versionary.py` script which implements the new versioning scheme: coreos/fedora-coreos-releng-automation#50
jlebon
added a commit
to coreos/fedora-coreos-pipeline
that referenced
this pull request
Dec 17, 2019
This uses the new `versionary.py` script which implements the new versioning scheme: coreos/fedora-coreos-releng-automation#50
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This script implements the versioning scheme as described in:
coreos/fedora-coreos-tracker#211
The next step is to use this in the FCOS pipeline to drive versioning.