Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new Jenkins job to build containers for kola #959

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

jbtrystram
Copy link
Contributor

@jbtrystram jbtrystram commented Feb 13, 2024

Add a new Jenkins job to build containers for kola

Some kola tests require external images. This job will build
and publish the images present under the test/containers path
of coreos-assembler.

Inital PR for coreos-assembler: https://github.com/coreos/coreos-assembler/pull/3727

x-ref https://github.com/coreos/fedora-coreos-tracker/issues/1639

Once coreos/coreos-assembler#3727 is merged i'll need to create the repos in quay and update the default values, before merging this one.

@jbtrystram jbtrystram force-pushed the add-coreos-kola-images branch 3 times, most recently from 148cde7 to e08cf8a Compare February 15, 2024 09:22
@jbtrystram jbtrystram marked this pull request as ready for review February 15, 2024 09:27
jobs/build-kola-containers.Jenkinsfile Outdated Show resolved Hide resolved
jobs/build-kola-containers.Jenkinsfile Outdated Show resolved Hide resolved
jobs/build-kola-containers.Jenkinsfile Outdated Show resolved Hide resolved
jobs/build-kola-containers.Jenkinsfile Outdated Show resolved Hide resolved
jobs/build-kola-containers.Jenkinsfile Outdated Show resolved Hide resolved
jobs/build-kola-containers.Jenkinsfile Outdated Show resolved Hide resolved
jobs/build-kola-containers.Jenkinsfile Outdated Show resolved Hide resolved
jobs/build-kola-containers.Jenkinsfile Outdated Show resolved Hide resolved
jobs/build-kola-containers.Jenkinsfile Outdated Show resolved Hide resolved
jobs/build-kola-containers.Jenkinsfile Outdated Show resolved Hide resolved
@jbtrystram jbtrystram force-pushed the add-coreos-kola-images branch 4 times, most recently from d4886bf to b343c89 Compare February 20, 2024 15:29
@jbtrystram
Copy link
Contributor Author

I updated this PR with a few changes following @jlebon review :

  • Only publish "latest" tagged manifest ( as we decided to only run on main)
  • Abort early (but with success) if no changes were made in $PATH_TO_CONTEXTS (see L89-108)
  • Add a FORCE flag to force a rebuild
  • Publishing intermediate images to the staging repo
  • Addressing the other review comments

jobs/build-kola-containers.Jenkinsfile Outdated Show resolved Hide resolved
jobs/build-kola-containers.Jenkinsfile Outdated Show resolved Hide resolved
jobs/build-kola-containers.Jenkinsfile Outdated Show resolved Hide resolved
jobs/build-kola-containers.Jenkinsfile Outdated Show resolved Hide resolved
jobs/build-kola-containers.Jenkinsfile Outdated Show resolved Hide resolved
@jbtrystram jbtrystram force-pushed the add-coreos-kola-images branch 2 times, most recently from 8355381 to 104b4ac Compare March 5, 2024 16:16
@jbtrystram
Copy link
Contributor Author

jbtrystram commented Mar 5, 2024

@jlebon I just squashed all the commit and pushed an update.
One change i made last is that if FORCE is set, then the whole git diff thing is not even tried. That will allow the initial run (where skopeo would have failed because no inital image to look for the commit reference)

jobs/build-kola-containers.Jenkinsfile Outdated Show resolved Hide resolved
jobs/build-kola-containers.Jenkinsfile Outdated Show resolved Hide resolved
jobs/build-kola-containers.Jenkinsfile Outdated Show resolved Hide resolved
jobs/build-kola-containers.Jenkinsfile Outdated Show resolved Hide resolved
jobs/build-kola-containers.Jenkinsfile Outdated Show resolved Hide resolved
jobs/build-kola-containers.Jenkinsfile Outdated Show resolved Hide resolved
jobs/build-kola-containers.Jenkinsfile Outdated Show resolved Hide resolved
jobs/build-kola-containers.Jenkinsfile Outdated Show resolved Hide resolved
@jbtrystram jbtrystram force-pushed the add-coreos-kola-images branch from 104b4ac to 72d6b0a Compare March 19, 2024 08:52
Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One final comment, otherwise LGTM!

jobs/build-kola-containers.Jenkinsfile Show resolved Hide resolved
@jbtrystram jbtrystram force-pushed the add-coreos-kola-images branch from 72d6b0a to 46afa1d Compare March 19, 2024 19:28
Some kola tests require external images. This job will build
and publish the images present under the test/containers path
of coreos-assembler.

Inital PR for coreos-assembler: coreos/coreos-assembler#3727

x-ref coreos/fedora-coreos-tracker#1639
@jlebon jlebon force-pushed the add-coreos-kola-images branch from 46afa1d to 6d2f2b5 Compare March 19, 2024 21:09
@jlebon jlebon merged commit 686b74d into coreos:main Mar 19, 2024
2 checks passed
jbtrystram added a commit to jbtrystram/coreos-assembler that referenced this pull request Mar 20, 2024
Now that coreos/fedora-coreos-pipeline#959
is merged, we have these images built by the coreOS CI and
hosted on the quay.io/coreos-assembler org.

Point tests that requires containers to use images from the
coreos-assembler org.

See  coreos#3727
Fixes coreos/fedora-coreos-tracker#1639
jbtrystram added a commit to jbtrystram/coreos-assembler that referenced this pull request Mar 20, 2024
Now that coreos/fedora-coreos-pipeline#959
is merged, we have these images built by the coreOS CI and
hosted on the quay.io/coreos-assembler org.

Point tests that requires containers to use images from the
coreos-assembler org.

See  coreos#3727
Fixes coreos/fedora-coreos-tracker#1639
jlebon pushed a commit to coreos/coreos-assembler that referenced this pull request Mar 20, 2024
Now that coreos/fedora-coreos-pipeline#959
is merged, we have these images built by the coreOS CI and
hosted on the quay.io/coreos-assembler org.

Point tests that requires containers to use images from the
coreos-assembler org.

See  #3727
Fixes coreos/fedora-coreos-tracker#1639
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants