Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pipeline: also test metal4k installs #218

Merged
merged 1 commit into from
May 25, 2020
Merged

Conversation

jlebon
Copy link
Member

@jlebon jlebon commented Apr 2, 2020

kola testiso knows how to do this now!

coreos/coreos-assembler#1312

@jlebon
Copy link
Member Author

jlebon commented Apr 16, 2020

Rebased this now! Though not tested in a developer pipeline.

@jlebon
Copy link
Member Author

jlebon commented Apr 16, 2020

Actually, we should use coreos/coreos-assembler#1358 first before merging this so we avoid recompressing a bunch of times.

cgwalters added a commit to cgwalters/coreos-installer that referenced this pull request Apr 17, 2020
This is done in the RHCOS pipeline and will be done soon in FCOS
coreos/fedora-coreos-pipeline#218

Also switch to explicit scenario list as another workaround
for coreos/coreos-assembler#1365
cgwalters added a commit to cgwalters/coreos-installer that referenced this pull request Apr 17, 2020
This is done in the RHCOS pipeline and will be done soon in FCOS
coreos/fedora-coreos-pipeline#218

Also switch to explicit scenario list as another workaround
for coreos/coreos-assembler#1365
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

`kola testiso` knows how to do this now!

coreos/coreos-assembler#1312

While we're here, make it run in parallel with the 512b one, and use
`kola` directly instead of `cosa kola`.
@jlebon jlebon force-pushed the pr/metal4k-test branch from b9c2645 to afe9e47 Compare May 20, 2020 14:18
@jlebon
Copy link
Member Author

jlebon commented May 20, 2020

OK, updated this to use cosa compress --artifact metal --artifact metal4k!

@dustymabe
Copy link
Member

still LGTM

@jlebon jlebon merged commit e9e40da into coreos:master May 25, 2020
@jlebon jlebon deleted the pr/metal4k-test branch May 25, 2020 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants