-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bare-metal: use CLI instead of kargs for ISO path #26
Conversation
Works on top of #25. |
yeah I think we discussed this briefly the other day. We should probably see how this fits in with the strategy we wrote down. I do agree this looks nice. Let's talk tomorrow. |
@jlebon - rebase? |
235d381
to
563eb03
Compare
Rebased! |
One possible problem with this approach is the fact that it doesn't carry forward the 'networking kargs' into the first boot, but I think it's worth exploring. I do like this approach as it seems simple and it does encourage the user to use the live system. Ultimately, though, we should probably document both ways. |
563eb03
to
d7719fa
Compare
Just to put this in more context, this page is the first introduction to installing on bare metal. Before going the full automated, bells-and-whistles path (with high upfront cost), we need the vanilla/manual path (with low upfront cost) that most users will be willing to work through to try out.
Yeah, we definitely need to document this, and the fully-automated-via-Ignition case. But I don't think we should jump straight to that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Do we have a running list of other things like this we'd like to get documented? |
From my notes, I think we wanted to keep these cases:
If we keep kargs and we add this on top, we have 1&2 covered. Thus, I'd probably rework this PR to introduce two sections, and have content in both. |
Slight proposed change: We only document one way to install here and create a dedicated page for "other ways to install". Here we document the "interactive coreos-installer via Live ISO" method. On the other page we document:
|
Yup, makes sense to me overall. What I'm questioning is the value of documenting the kargs via live ISO path. If it's not automated, then why not use the CLI? Or is it possible to use the live ISO in an automated fashion in some situations? If so, we should just document the kargs in that context only (automation), just like PXE. |
I think it is automatable via tools like virt-install but I think you're right. We should just make the "topic" of this section about automation and mention PXE as the primary use case and leave it open to other use cases as well. |
I find using the CLI more elegant. Plus, you get better progress reporting. Plus it introduces them to the live ISO in a more natural way (I didn't spell it out, but users can infer from the output that they've just booted into a working FCOS instance and they can play around as they want).
d7719fa
to
0d7e23a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I find using the CLI more elegant. Plus, you get better progress
reporting. Plus it introduces them to the live ISO in a more natural way
(I didn't spell it out, but users can infer from the output that they've
just booted into a working FCOS instance and they can play around as
they want).