Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rhcos-4.14] ignition-ostree: make sure we don't mount /sysroot before transposefs #2534

Merged
merged 2 commits into from
Aug 2, 2023

Conversation

jmarrero
Copy link
Member

@jmarrero jmarrero commented Aug 1, 2023

When enabling multipath the ignition-ostree-mount-firstboot-sysroot service loses to the systemd's generator, which causes /sysroot to be mounted before we finish transposing the fs. This change makes sure we wait to mount the /sysroot until we are done. This was reported via: https://issues.redhat.com/browse/OCPBUGS-16157

Cherry-picked from #2526 & #2535

When enabling multipath the ignition-ostree-mount-firstboot-sysroot
service loses to the systemd's generator, which causes /sysroot to
be mounted before we finish transposing the fs. This change makes
sure we wait to mount the /sysroot until we are done.
This was reported via: https://issues.redhat.com/browse/OCPBUGS-16157
@jmarrero jmarrero requested a review from cgwalters August 1, 2023 22:19
@jmarrero jmarrero changed the title ignition-ostree: make sure we don't mount /sysroot before transposefs [rhcos-4.14] ignition-ostree: make sure we don't mount /sysroot before transposefs Aug 1, 2023
@cgwalters
Copy link
Member

Makes sense...I didn't think we'd branched yet for 4.14 though? But the branch exists so we must have?

cgwalters
cgwalters previously approved these changes Aug 1, 2023
@cgwalters cgwalters enabled auto-merge (rebase) August 1, 2023 22:38
@jmarrero jmarrero marked this pull request as draft August 2, 2023 02:01
auto-merge was automatically disabled August 2, 2023 02:01

Pull request was converted to draft

@jmarrero
Copy link
Member Author

jmarrero commented Aug 2, 2023

converting to draft to pull in #2535 once it's merged too.

@jmarrero jmarrero marked this pull request as ready for review August 2, 2023 15:05
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmarrero jmarrero merged commit b7b6920 into coreos:rhcos-4.14 Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants