Stop discarding disk contents #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 7b89735 we started issuing block discard requests over the destination disk, before install and after install failure, as a courtesy to SSD wear levelers and LVM thin pools. However, this assumes that the entire disk is ours to discard. Users might want to reprovision an existing machine without disturbing a data partition they've created on the boot disk; their Ignition config can then recreate the data partition in the same place and reuse the filesystem inside. Discard the discard functionality for now. We shouldn't require users to explicitly specify --dont-delete-my-data, and the semantics of --delete-my-data (under whatever name, e.g. --discard-device) would be difficult to explain relative to the value they provide. Users can still run blkdiscard(8) before coreos-installer if they need that functionality. Fixes #170.
cgwalters
approved these changes
Feb 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 7b89735 we started issuing block discard requests over the destination disk, before install and after install failure, as a courtesy to SSD wear levelers and LVM thin pools. However, this assumes that the entire disk is ours to discard. Users might want to reprovision an existing machine without disturbing a data partition they've created on the boot disk; their Ignition config can then recreate the data partition in the same place and reuse the filesystem inside.
Discard the discard functionality for now. We shouldn't require users to explicitly specify
--dont-delete-my-data, and the semantics of--delete-my-data(under whatever name, e.g.--discard-device) would be difficult to explain relative to the value they provide. Users can still runblkdiscard(8)before coreos-installer if they need that functionality.Fixes #170.