Remove code invoking Anaconda to build disk images #835
Conversation
|
Looks sane. Would be good to get some of the multi-arch folks to review. cc: @tuan-hoang1 @jcajka @Prashanth684 |
|
lgtm! |
cgwalters
force-pushed
the
remove-libvirt
branch
from
cdb7e8f to
64883f7
Compare
| fi | ||
| ;; | ||
| "x86_64"|"aarch64"|"s390x"|"ppc64le") ;; | ||
| *) fatal "$basearch is not supported for this command" ;; |
There was a problem hiding this comment.
Hmm, would it make sense to just move it somewhere near the top of cmdlib.sh and have a more generic error?
There was a problem hiding this comment.
Possibly - though I'd like to keep this PR scoped to mostly just deleting code so we can back it out more easily if need be.
However, thinking about this one more - it feels a bit harsh to people porting to other architectures if we make cosa refuse to work at all, versus just the disk image building part. So I think this probably makes sense here still.
Since ppc64le has some support for this that just landed in master, remove most of the code and references to Anaconda. We create disk images directly on all architectures. Some more background in: coreos#91
cgwalters
force-pushed
the
remove-libvirt
branch
from
64883f7 to
d140526
Compare
|
Fixed last nit and rebased 🏄♂️ - any objections to pushing the green button on this soon? |
Ahh right, that's #865. |
Since ppc64le has some support for this that just landed in master,
remove most of the code and references to Anaconda. We create
disk images directly on all architectures.
Some more background in:
#91