Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rhcos-4.16]: mantle/kola: make iscsi tests use virtiofs mounted COSA rootfs #4020

Merged
merged 3 commits into from
Feb 4, 2025

Conversation

marmijo
Copy link
Member

@marmijo marmijo commented Feb 4, 2025

Backport #4013 to rhcos-4.16.

In this case we'll run the podman container with --rootfs instead
of pulling a full 4+ GiB COSA image from quay for kola qemuexec.

This saves us quite a bit of time and bandwidth usage during a
pipeline run because we have more than 1 iscsi test.

This should also take care of coreos/fedora-coreos-tracker#1866
because we are no longer pulling this particular container from quay.

Pulling COSA from quay takes a good amount of time. Let's bump
this so the service doesn't timeout like has been seen:

```
Jan 27 13:27:10 localhost systemd[1]: Starting Boot VM over iSCSI...
Jan 27 13:28:21 localhost chronyd[1116]: Can't synchronise: no selectable sources
Jan 27 13:28:21 localhost chronyd[1116]: Source 149.28.200.179 replaced with 67.217.246.204 (2.rhel.pool.ntp.org)
Jan 27 13:31:16 localhost systemd[1289]: Created slice User Background Tasks Slice.
Jan 27 13:31:16 localhost systemd[1289]: Starting Cleanup of User's Temporary Files and Directories...
Jan 27 13:31:16 localhost systemd[1289]: Finished Cleanup of User's Temporary Files and Directories.
Jan 27 13:31:26 localhost systemd[1]: coreos-iscsi-vm.service: start operation timed out. Terminating.
Jan 27 13:31:26 localhost systemd[1]: coreos-iscsi-vm.service: Main process exited, code=exited, status=1/FAILURE
Jan 27 13:31:26 localhost systemd[1]: coreos-iscsi-vm.service: Failed with result 'timeout'.
```
We've seen errors in the RHCOS pipeline where the iSCSI tests
are hitting the 10m timeout. We could bump the timeout, but
first let's try pulling the COSA image in a separate unit so
that it can happen in parallel with the install over iSCSI
so that when we're ready to start the VM the image is already
there.
In this case we'll run the podman container with --rootfs instead
of pulling a full 4+ GiB COSA image from quay for `kola qemuexec`.

This saves us quite a bit of time and bandwidth usage during a
pipeline run because we have more than 1 iscsi test.

This should also take care of coreos/fedora-coreos-tracker#1866
because we are no longer pulling this particular container from quay.
Copy link
Contributor

@jbtrystram jbtrystram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@aaradhak
Copy link
Member

aaradhak commented Feb 4, 2025

/retest

Copy link

openshift-ci bot commented Feb 4, 2025

@marmijo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/rhcos f616ad8 link true /test rhcos

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@marmijo
Copy link
Member Author

marmijo commented Feb 4, 2025

CI is failing with:

Errors during downloading metadata for repository 'f39-coreos-continuous':
  - Status code: 403 for https://kojipkgs.fedoraproject.org/repos-dist/f39-coreos-continuous/latest/x86_64/repodata/repomd.xml (IP: 10.3.163.77)
Error: Failed to download metadata for repo 'f39-coreos-continuous': Cannot download repomd.xml: Cannot download repodata/repomd.xml: All mirrors were tried

@dustymabe
Copy link
Member

yeah. See https://pagure.io/koji/issue/4295#comment-953957

I ran that and re-triggered CI here.

/retest

@dustymabe dustymabe enabled auto-merge (rebase) February 4, 2025 19:36
@dustymabe dustymabe merged commit 2b5dcd7 into coreos:rhcos-4.16 Feb 4, 2025
4 of 5 checks passed
@marmijo
Copy link
Member Author

marmijo commented Feb 4, 2025

Thanks @dustymabe!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants