Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/ignition/kdump: add a remote NFS kdump test #3911

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

jbtrystram
Copy link
Contributor

This way we have good coverage of most-used kdump features. Some context on the NFS kdump configuration coreos/fedora-coreos-tracker#1729

This way we have good coverage of most-used kdump features.
Some context on the NFS kdump configuration coreos/fedora-coreos-tracker#1729
@aaradhak aaradhak changed the title tests/ingition/kdump: add a remote NFS kdump test tests/ignition/kdump: add a remote NFS kdump test Oct 23, 2024
Copy link
Member

@travier travier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not tested this but LGTM. This is also not too bad in terms of runtime:

[2024-10-22T14:46:12.497Z] --- PASS: ext.config.kdump.crash (147.11s)
[2024-10-22T14:48:33.065Z] --- PASS: kdump.crash.ssh (116.10s)
[2024-10-22T14:52:25.865Z] --- PASS: kdump.crash.nfs (137.53s)

Thanks for working on this.

@jbtrystram jbtrystram merged commit b10d8dc into coreos:main Oct 23, 2024
5 checks passed
@dustymabe
Copy link
Member

note this test failed on all 4 architectures in the next-devel bump-lockfile job that ran today: https://jenkins-fedora-coreos-pipeline.apps.ocp.fedoraproject.org/job/bump-lockfile/1399/display/redirect

@jbtrystram jbtrystram deleted the kdump_nfs branch October 24, 2024 02:50
@jbtrystram
Copy link
Contributor Author

jbtrystram commented Oct 24, 2024

note this test failed on all 4 architectures in the next-devel bump-lockfile job that ran today: jenkins-fedora-coreos-pipeline.apps.ocp.fedoraproject.org/job/bump-lockfile/1399/display/redirect

I am looking into it, it looks like the second initramfs simply times out waiting on a disk :

[  *** ] Job dev-disk-by\x2dpath-pci\x2d0000…tart running (1min 48s / no limit)

@jbtrystram
Copy link
Contributor Author

Not a lot of change in this build :

[2024-10-23T23:44:16.144Z] ostree diff commit from: 5fcdd5fffce9172d2f7e7c1472da057e6f6ab80de6e2a28660cacd2a9e2b377a

[2024-10-23T23:44:16.144Z] ostree diff commit to:   2fe5a23c28f5e85a571c9b89646112e589ffa90f522c444a67d184f09056fe71

[2024-10-23T23:44:16.144Z] Upgraded:

[2024-10-23T23:44:16.144Z]   ignition 2.19.0-2.fc41 -> 2.20.0-1.fc41

jbtrystram added a commit to jbtrystram/fedora-coreos-config that referenced this pull request Oct 24, 2024
We were not testing this until recently [1] so it slipped through.

Upstream issue : rhkdump/kdump-utils#52
[1] coreos/coreos-assembler#3911
dustymabe pushed a commit to coreos/fedora-coreos-config that referenced this pull request Oct 24, 2024
We were not testing this until recently [1] so it slipped through.

Upstream issue : rhkdump/kdump-utils#52
[1] coreos/coreos-assembler#3911
@dustymabe
Copy link
Member

note. opened a revert in #3914 since this is failing in RHCOS too. We can re-apply when it is passing everywhere.

jbtrystram added a commit to jbtrystram/coreos-assembler that referenced this pull request Oct 31, 2024
This is prep work for enabling kdump over NFS testing. The previous
attempt in coreos#3911 used an
image from openshift E2E tests, but I didn't pay attention to the image
and the latest tag is not a multiarch manifest, so the pipeline tripped
on that.

Building the image ourselves will fix that.
jbtrystram added a commit to jbtrystram/coreos-assembler that referenced this pull request Oct 31, 2024
This is prep work for enabling kdump over NFS testing. The previous
attempt in coreos#3911 used an
image from openshift E2E tests, but I didn't pay attention to the image
and the latest tag is not a multiarch manifest, so the pipeline tripped
on that.

Building the image ourselves will fix that.
jbtrystram added a commit that referenced this pull request Nov 2, 2024
This is prep work for enabling kdump over NFS testing. The previous
attempt in #3911 used an
image from openshift E2E tests, but I didn't pay attention to the image
and the latest tag is not a multiarch manifest, so the pipeline tripped
on that.

Building the image ourselves will fix that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants