Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require platforms.yaml in config #2899

Merged
merged 1 commit into from
Jan 11, 2023
Merged

Require platforms.yaml in config #2899

merged 1 commit into from
Jan 11, 2023

Conversation

bgilbert
Copy link
Contributor

@bgilbert bgilbert commented Jun 2, 2022 •
edited
Loading

Now that both FCOS and RHCOS ship platforms.yaml, we can drop the fallback to the legacy console configuration when that file is missing.

@openshift-ci
Copy link

openshift-ci bot commented Jun 2, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@bgilbert bgilbert mentioned this pull request Jun 2, 2022
Merged
cgwalters
cgwalters previously approved these changes Jun 2, 2022
View reviewed changes
Copy link
Member

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me at a high level.

@openshift-ci
Copy link

openshift-ci bot commented Jun 25, 2022

@bgilbert: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bgilbert bgilbert marked this pull request as ready for review January 4, 2023 21:51
@bgilbert
Require platforms.yaml in config
d3017bf 
Both FCOS and RHCOS ship it now.  Drop the fallback to the legacy console
configuration when platforms.yaml is missing.
@bgilbert
Copy link
Contributor Author

bgilbert commented Jan 4, 2023

Okay, ready for review!

dustymabe
dustymabe approved these changes Jan 5, 2023
View reviewed changes
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dustymabe
Copy link
Member

/retest

2 similar comments
@bgilbert
Copy link
Contributor Author

bgilbert commented Jan 5, 2023

/retest

@bgilbert
Copy link
Contributor Author

/retest

@bgilbert bgilbert merged commit 39bf542 into coreos:main Jan 11, 2023
@bgilbert bgilbert deleted the console-legacy branch January 11, 2023 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dustymabe dustymabe dustymabe approved these changes

@jlebon jlebon jlebon approved these changes

@cgwalters cgwalters cgwalters left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bgilbert @dustymabe @cgwalters @jlebon @openshift-merge-robot