Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Clean /var after Anaconda #107

Closed
wants to merge 1 commit into from

Conversation

cgwalters
Copy link
Member

This way we are truly starting from a clean slate. It means
we know we won't have a random-seed for example. OSTree is
designed to support this but unless we use it by default
we aren't really testing it.

This actually now breaks things since currently the creation of
the core user is in image.ks, which we need to fix:
coreos/afterburn#90 (comment)

This way we are truly starting from a clean slate.  It means
we know we won't have a `random-seed` for example.  OSTree is
designed to support this but unless we use it *by default*
we aren't really testing it.

This actually now breaks things since currently the creation of
the `core` user is in `image.ks`, which we need to fix:
coreos/afterburn#90 (comment)
@cgwalters cgwalters added the help wanted Extra attention is needed label Sep 18, 2018
shift

coreos_gf_run_mount "${src}"
coreos_gf glob rm-rf ${stateroot}'/var/*'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need a coreos_gf_shutdown like in gf-oemid ?

@dustymabe
Copy link
Member

if we make this change does it make it harder to use the assembler for el7 ? IOW can el7 handle the start with empty /var/ as good as Fedora can?

@cgwalters
Copy link
Member Author

if we make this change does it make it harder to use the assembler for el7

Maybe, let's not concern ourselves too much with that quite yet. I mean, let's consider it but we can't block on it. If we need to carry hacks we'll figure out whether to add them here later, or fork this repo for el7, etc.

@dustymabe
Copy link
Member

dustymabe commented Sep 19, 2018

let's consider it but we can't block on it.

that's fine. 👍

you added the "help wanted" label. Can you describe what you're looking for?

@dustymabe dustymabe added the WIP PR still being worked on label Sep 19, 2018
@cgwalters cgwalters removed the help wanted Extra attention is needed label Sep 19, 2018
@cgwalters
Copy link
Member Author

you added the "help wanted" label. Can you describe what you're looking for?

Change our build or config process to have Ignition create the core user, but only if no other users are specified - per the discussion linked above.

@cgwalters
Copy link
Member Author

I forgot about this PR and ended up reimplementing it in #205

@cgwalters cgwalters closed this Nov 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP PR still being worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants