Skip to content

Commit

Permalink
kola/testiso: include more details in "Success" string
Browse files Browse the repository at this point in the history
Such as whether it was BIOS or UEFI, and whether it was the metal or the
metal4k image.
  • Loading branch information
jlebon committed Apr 1, 2020
1 parent 7ed8b74 commit bbae02a
Showing 1 changed file with 10 additions and 2 deletions.
12 changes: 10 additions & 2 deletions mantle/cmd/kola/testiso.go
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ func runTestIso(cmd *cobra.Command, args []string) error {
if err := testPXE(instPxe, completionfile); err != nil {
return err
}
fmt.Printf("Successfully tested PXE live installer for %s\n", kola.CosaBuild.Meta.OstreeVersion)
printSuccess("PXE")
}

if !noiso {
Expand All @@ -154,7 +154,7 @@ func runTestIso(cmd *cobra.Command, args []string) error {
if err := testLiveIso(instIso, completionfile); err != nil {
return err
}
fmt.Printf("Successfully tested ISO live installer for %s\n", kola.CosaBuild.Meta.OstreeVersion)
printSuccess("ISO")
}
}

Expand All @@ -165,6 +165,14 @@ func runTestIso(cmd *cobra.Command, args []string) error {
return nil
}

func printSuccess(mode string) {
metaltype := "metal"
if kola.QEMUOptions.Native4k {
metaltype = "metal4k"
}
fmt.Printf("Successfully tested %s live installer for %s on %s (%s)\n", mode, kola.CosaBuild.Meta.OstreeVersion, kola.QEMUOptions.Firmware, metaltype)
}

func testPXE(inst platform.Install, completionfile string) error {
completionstamp := "coreos-installer-test-OK"

Expand Down

0 comments on commit bbae02a

Please sign in to comment.