-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
packaging: Add systemd unit to trigger updates on boot #803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a systemd service unit to trigger an adoption and update on every boot. Note that the service is intentionally not enabled by default as it should be up to the distribution to add a systemd preset if auto-update for the bootloader is desired. This unit does not come with any specific restrictions (i.e. EFI or BIOS only). For an assesment of the safety of updates as performed by bootupd, see coreos#454. Distributiuons should also apply the restrictions (i.e. EFI or BIOS only for example) as needed as unit files overrides. Notably, Fedora CoreOS can not yet enable automatic updates until we get support for the multiple EFI partitions for RAID setups. See: coreos/fedora-coreos-tracker#1468 See: coreos/fedora-coreos-config#3042 Initial version from: coreos#716 Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2332868
Untested yet (but it's a copy paste & update from the previous PR). |
cgwalters
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One hesitation I have is that in the medium term I think we want bootupd integrated more with the OS update tool by default.
But yes, this is clearly better than having it external.
travier
added a commit
to travier/fedora-atomic-desktops-devel
that referenced
this pull request
Feb 5, 2025
travier
added a commit
to travier/fedora-atomic-desktops-devel
that referenced
this pull request
Feb 6, 2025
travier
added a commit
to travier/bootupd
that referenced
this pull request
Feb 7, 2025
This folder is already in Cargo.toml (leftover from our previous units) so let's re-use that instead of including the contrib folder that has the specfile in it as well. Fixes: coreos#803
pierrepinon
pushed a commit
to pierrepinon/workstation-ostree-config
that referenced
this pull request
Feb 14, 2025
pierrepinon
pushed a commit
to pierrepinon/workstation-ostree-config
that referenced
this pull request
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
packaging: Add systemd unit to trigger updates on boot
Add a systemd service unit to trigger an adoption and update on every
boot.
Note that the service is intentionally not enabled by default as it
should be up to the distribution to add a systemd preset if auto-update
for the bootloader is desired.
This unit does not come with any specific restrictions (i.e. EFI or BIOS
only). For an assesment of the safety of updates as performed by
bootupd, see #454.
Distributiuons should also apply the restrictions (i.e. EFI or BIOS only
for example) as needed as unit files overrides.
Notably, Fedora CoreOS can not yet enable automatic updates until we get
support for the multiple EFI partitions for RAID setups.
See: coreos/fedora-coreos-tracker#1468
See: coreos/fedora-coreos-config#3042
Initial version from: #716
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2332868
contrib/packaging/bootupd.spec: Fix EOL at EOF