Fix readelf parsing with more than 100 sections #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roccodev
changed the title
|
Thanks for your contribution, can you submit a PR to https://github.com/pebble-dev/pebble-firmware ? |
|
Sure! See pebble-dev#34 If you don't mind me asking, what is the difference between the two repos? |
The repo on |
This fixes readelf parsing for SDK builds when an ELF has more than 100 sections. The parsing logic previously assumed that section IDs could only go up to 99 (2 digits), this makes it look for a closing bracket instead.
roccodev
force-pushed
the
fix/readelf-99-sections
branch
from
517a549 to
59adb77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes
readelfparsing for SDK builds when an ELF has more than 100 sections. I encountered this years ago when trying to get Rust to work on the Pebble: https://github.com/pebble-rust/pebble-rust/blob/master/docs/TROUBLESHOOTING.md