-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for Python 3.8 #771
Conversation
d365efd
to
878ee94
Compare
878ee94
to
a2c6af5
Compare
Pull request was converted to draft
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #771 +/- ##
===========================================
- Coverage 87.46% 87.39% -0.07%
===========================================
Files 38 38
Lines 3166 3166
Branches 387 387
===========================================
- Hits 2769 2767 -2
- Misses 256 257 +1
- Partials 141 142 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Commit message "chore: Drop support for [...]" does not mention:
- "Remove Python 3.8 from Mypy configuration."
- "Remove Python 3.8 from Tox configuration."
- Readme says that Python 3.8 is supported.
3e0098d
to
13b3f36
Compare
13b3f36
to
ab442be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Commit message does not mention the Tox configuration.
- Stop running **tests** for Python **3.8** in CI/CD. - Remove **explicit** support for Python **3.8** from Python project configuration (`setup.py`, `setup.cfg`, and/or `pyproject.toml`). - Compile Python **dependency manifests** with the **next highest** Python version (**3.9**). - Remove Python **3.8** from **Black** configuration. - Remove support for Python **3.8** from Mypy configuration. - Remove support for Python **3.8** from Tox configuration. - Update documentation in README. Reasons for this change: - The end of support date of Python **3.8** is **2024-10-07**: - [PEP 569 – Python 3.8 Release Schedule → 3.8 Lifespan](https://peps.python.org/pep-0569/#lifespan) - [Status of Python versions](https://devguide.python.org/versions/) - Dependabot end-of-support date for Python **3.8** is **2025-02-05**: - [Closing down notice: Dependabot will no longer support Python version 3.8 ← GitHub Changelog](https://github.blog/changelog/2025-01-06-closing-down-notice-dependabot-will-no-longer-support-python-version-3-8/) Ref: https://app.shortcut.com/cordada/story/12613
Update code format for Mypy linter using Python 3.9 Ref: https://app.shortcut.com/cordada/story/12613 [12613]
ab442be
to
681f804
Compare
|
setup.py
,setup.cfg
, and/orpyproject.toml
).Reasons for this change:
Ref: https://app.shortcut.com/cordada/story/12613