Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python 3.8 #771

Merged
merged 2 commits into from
Mar 11, 2025
Merged

Conversation

fpinto-cdd
Copy link
Contributor

@fpinto-cdd fpinto-cdd commented Feb 24, 2025

  • Stop running tests for Python 3.8 in CI/CD.
  • Remove explicit support for Python 3.8 from Python project configuration (setup.py, setup.cfg, and/or pyproject.toml).
  • Compile Python dependency manifests with the next highest Python version (3.9).
  • Remove Python 3.8 from Black configuration.
  • Remove support for Python 3.8 from Mypy configuration.
  • Remove support for Python 3.8 from Tox configuration.
  • Update documentation in README.

Reasons for this change:

Ref: https://app.shortcut.com/cordada/story/12613

@fpinto-cdd fpinto-cdd added task Task or chore dependencies Pull requests that update a dependency file labels Feb 24, 2025
@fpinto-cdd fpinto-cdd self-assigned this Feb 24, 2025
@fpinto-cdd fpinto-cdd requested a review from a team as a code owner February 24, 2025 19:46
@fpinto-cdd fpinto-cdd enabled auto-merge February 24, 2025 21:22
@fpinto-cdd fpinto-cdd force-pushed the task/drop-support-for-python-3.8 branch 2 times, most recently from d365efd to 878ee94 Compare February 25, 2025 14:20
@jtrobles-cdd jtrobles-cdd changed the title chore: Drop support for Python 3.8 Drop support for Python 3.8 Feb 25, 2025
@fpinto-cdd fpinto-cdd force-pushed the task/drop-support-for-python-3.8 branch from 878ee94 to a2c6af5 Compare February 25, 2025 14:26
@fpinto-cdd fpinto-cdd marked this pull request as draft February 25, 2025 14:29
auto-merge was automatically disabled February 25, 2025 14:29

Pull request was converted to draft

Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.39%. Comparing base (2d41b16) to head (681f804).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #771      +/-   ##
===========================================
- Coverage    87.46%   87.39%   -0.07%     
===========================================
  Files           38       38              
  Lines         3166     3166              
  Branches       387      387              
===========================================
- Hits          2769     2767       -2     
- Misses         256      257       +1     
- Partials       141      142       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fpinto-cdd fpinto-cdd marked this pull request as ready for review February 25, 2025 14:37
Copy link
Member

@jtrobles-cdd jtrobles-cdd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Commit message "chore: Drop support for [...]" does not mention:
    • "Remove Python 3.8 from Mypy configuration."
    • "Remove Python 3.8 from Tox configuration."
  • Readme says that Python 3.8 is supported.

@fpinto-cdd fpinto-cdd force-pushed the task/drop-support-for-python-3.8 branch 2 times, most recently from 3e0098d to 13b3f36 Compare March 10, 2025 19:30
@fpinto-cdd fpinto-cdd requested a review from jtrobles-cdd March 10, 2025 19:31
@fpinto-cdd fpinto-cdd force-pushed the task/drop-support-for-python-3.8 branch from 13b3f36 to ab442be Compare March 10, 2025 19:31
@fpinto-cdd fpinto-cdd enabled auto-merge March 10, 2025 19:36
Copy link
Member

@jtrobles-cdd jtrobles-cdd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Commit message does not mention the Tox configuration.

- Stop running **tests** for Python **3.8** in CI/CD.
- Remove **explicit** support for Python **3.8** from
  Python project configuration (`setup.py`, `setup.cfg`, and/or `pyproject.toml`).
- Compile Python **dependency manifests** with the **next highest**
  Python version (**3.9**).
- Remove Python **3.8** from **Black** configuration.
- Remove support for Python **3.8** from Mypy configuration.
- Remove support for Python **3.8** from Tox configuration.
- Update documentation in README.

Reasons for this change:

- The end of support date of Python **3.8** is **2024-10-07**:
  - [PEP 569 – Python 3.8 Release Schedule → 3.8 Lifespan](https://peps.python.org/pep-0569/#lifespan)
  - [Status of Python versions](https://devguide.python.org/versions/)
- Dependabot end-of-support date for Python **3.8** is **2025-02-05**:
  - [Closing down notice: Dependabot will no longer support Python version 3.8 ← GitHub Changelog](https://github.blog/changelog/2025-01-06-closing-down-notice-dependabot-will-no-longer-support-python-version-3-8/)

Ref: https://app.shortcut.com/cordada/story/12613
Update code format for Mypy linter using Python 3.9

Ref: https://app.shortcut.com/cordada/story/12613 [12613]
@fpinto-cdd fpinto-cdd force-pushed the task/drop-support-for-python-3.8 branch from ab442be to 681f804 Compare March 11, 2025 20:26
@fpinto-cdd fpinto-cdd requested a review from jtrobles-cdd March 11, 2025 20:27
@fpinto-cdd fpinto-cdd merged commit d332205 into develop Mar 11, 2025
20 checks passed
@fpinto-cdd fpinto-cdd deleted the task/drop-support-for-python-3.8 branch March 11, 2025 20:31
@fpinto-cdd fpinto-cdd mentioned this pull request Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file task Task or chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants