Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Make tasks clean-build, clean-pyc, and clean-test #755

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

jtrobles-cdd
Copy link
Member

@jtrobles-cdd jtrobles-cdd commented Jan 8, 2025

This pull request includes updates to the Makefile to enhance the cleaning process by standardizing the use of the RM variable. The most important changes include replacing direct rm commands with ${RM} and improving the find command options for better compatibility and performance.

Enhancements to cleaning process:

  • Makefile: Replaced direct rm commands with ${RM} to standardize the removal process and ensure consistency across different environments.
  • Makefile: Improved find command options by using -iname for case-insensitive matching and -prune to optimize directory traversal.

@jtrobles-cdd jtrobles-cdd added the task Task or chore label Jan 8, 2025
@jtrobles-cdd jtrobles-cdd self-assigned this Jan 8, 2025
@jtrobles-cdd jtrobles-cdd requested a review from a team as a code owner January 8, 2025 21:22
@jtrobles-cdd jtrobles-cdd force-pushed the task/improve-cleaning-make-tasks branch from 857fa6e to 4b9ec9d Compare January 8, 2025 21:33
This commit includes changes to the `Makefile` to improve the
consistency and maintainability of the clean commands by using the
`RM` variable instead of hardcoding the `rm` command. The most
important changes include updates to the `clean-build`, `clean-pyc`,
and `clean-test` targets.

Improvements to clean commands:

- `clean-build`: Replaced hardcoded `rm` commands with `${RM}`
  variable and adjusted `find` commands to use `-iname` for
  case-insensitive matching and `-prune` for directory handling.
- `clean-pyc`: Simplified `find` commands by using `-delete` for
  file removal and `${RM}` variable for consistency.
- `clean-test`: Replaced hardcoded `rm` commands with `${RM}`
  variable for consistency.
@jtrobles-cdd jtrobles-cdd force-pushed the task/improve-cleaning-make-tasks branch from 4b9ec9d to 416b93e Compare January 8, 2025 21:41
Copy link

sonarqubecloud bot commented Jan 8, 2025

@jtrobles-cdd jtrobles-cdd merged commit 6e0b09d into develop Jan 8, 2025
19 checks passed
@jtrobles-cdd jtrobles-cdd deleted the task/improve-cleaning-make-tasks branch January 8, 2025 21:45
@jtrobles-cdd jtrobles-cdd mentioned this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task Task or chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant