extras: Pydantic Rut type regex is not compliant with JSON Schema
#722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The regular expression used to validate RUTs in `_RutPydanticAnnotation` results in Pydantic generating an invalid JSON Schema because the regex uses named groups, which are not supported by the JavaScript regular expression syntax used by JSON Schema (and OpenAPI).
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #722 +/- ##
===========================================
+ Coverage 87.63% 87.65% +0.01%
===========================================
Files 38 38
Lines 3139 3142 +3
Branches 386 386
===========================================
+ Hits 2751 2754 +3
Misses 246 246
Partials 142 142 ☔ View full report in Codecov by Sentry. |
svillegas-cdd
approved these changes
Oct 25, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regular expression used to validate RUTs in
_RutPydanticAnnotationresults in Pydantic generating an invalid JSON Schema because the regex uses named groups, which are not supported by the JavaScript regular expression syntax used by JSON Schema (and OpenAPI).