Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable type checking for lxml #702

Merged
merged 3 commits into from
Sep 26, 2024
Merged

Conversation

jtrobles-cdd
Copy link
Member

  • Install Python package types-lxml.
  • Update Mypy configuration.
  • Fix errors reported by Mypy after enabling type checking for lxml.

@jtrobles-cdd jtrobles-cdd added the task Task or chore label Sep 26, 2024
@jtrobles-cdd jtrobles-cdd self-assigned this Sep 26, 2024
@jtrobles-cdd jtrobles-cdd requested a review from a team as a code owner September 26, 2024 00:12
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.53%. Comparing base (8cc9206) to head (a70ac21).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #702      +/-   ##
===========================================
+ Coverage    87.45%   87.53%   +0.08%     
===========================================
  Files           38       38              
  Lines         3093     3113      +20     
  Branches       382      382              
===========================================
+ Hits          2705     2725      +20     
  Misses         246      246              
  Partials       142      142              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jtrobles-cdd jtrobles-cdd force-pushed the task/enable-type-checking-lxml branch from 8a9a360 to a70ac21 Compare September 26, 2024 00:25
Copy link

@jtrobles-cdd jtrobles-cdd merged commit d257a60 into develop Sep 26, 2024
20 checks passed
@jtrobles-cdd jtrobles-cdd deleted the task/enable-type-checking-lxml branch September 26, 2024 00:29
@jtrobles-cdd jtrobles-cdd mentioned this pull request Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task Task or chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant