Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RuleGroup documentation says it is not concurrent safe, but it still has a
RWMutex
that is not properly used: theGetRules
method locks for read but none of the write methods honor the mutex, so the lock is not effective and the method is not concurrent safe (as opposed to what its doc string says).Should we just remove the lock and keep it concurrent unsafe as the RuleGroup type documentation says, and remove the sync overhead, or should I better make the RuleGroup concurrent safe and properly lock on writes?
Note: that go.mod and go.sum can only be modified for tested dependency updates or justified new features.
Make sure that you've checked the boxes below before you submit PR:
Thanks for your PR ❤️