Updates to latest tinygo and coraza-wasilibs #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuraaga
approved these changes
Oct 2, 2023
| @@ -20,7 +20,7 @@ import ( | |||
| ) | |||
|
|
|||
| var minGoVersion = "1.20" | |||
| var tinygoMinorVersion = "0.29" | |||
| var tinygoMinorVersion = "0.30" | |||
There was a problem hiding this comment.
BTW I have been thinking compatibility has been good for the past 3-4 releases I think. We could probably make this check a minimum similar to the Go version check.
There was a problem hiding this comment.
sounds like something we could do, any advice @deadprogram?
There was a problem hiding this comment.
I opened #232 if we feel we can relax tinygo version check
jcchavezs
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tinygo
0.30.0is out and our tinygo version check is very strict. The update looks okay.Updated also coraza-wasilibs that includes go-re2 latest release.