Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin actions for Flagged comments #315

Merged
merged 8 commits into from
Feb 15, 2017
Merged

Admin actions for Flagged comments #315

merged 8 commits into from
Feb 15, 2017

Conversation

okbel
Copy link
Contributor

@okbel okbel commented Feb 15, 2017

What does this PR do?

  • Adds Admin actions for Flagged comments
  • Changes null for NONE
  • Solves the Flag Queue issue. It returns only NONE or PREMOD statuses for flagged comments.
  • Old routes, and old actions clean up. (/comments endpoint free)

How do I test this PR?

  • Flag a comment
  • Go to Moderation
  • Check the actions for flagged comments

@okbel okbel self-assigned this Feb 15, 2017
@okbel okbel requested a review from jde February 15, 2017 16:51
Copy link

@jde jde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments are remaining in the flag queue after being ACCEPTED.

The flag queue should not show comments that have already been acted on by a moderator (aka, ACCEPTED or REJECTED)

@jde
Copy link

jde commented Feb 15, 2017

Also, in a related issue, I'm seeing rejected comments in the All list. The All list should only show comments that need moderator attention (those in the Premod and Flagged lists).

Sorry this is confusing and not well documented. Design is working on making this section clearer.

@okbel
Copy link
Contributor Author

okbel commented Feb 15, 2017

@jde The 'All Queue' was removed after a Design Meeting until further research is completed. (It wasn't updated to master)

About the comments that have been ACCEPTED or REJECTED showing in the Flagged Queue. I'm working on a workaround for this apollographql/graphql-tag#47 since I need to perform a statuses: [null, PREMOD] and I'm getting an error because of null. (Only happens on the FE. The Query is valid)

@okbel
Copy link
Contributor Author

okbel commented Feb 15, 2017

Updated and ready to be tested! (Description updated too) Super thanks to @wyattjoh who addressed this super quickly. Also, we removed all the actions with /comments endpoints involved, and some old routes!

@jde

@jde jde merged commit a37e103 into master Feb 15, 2017
@jde jde deleted the flags-button branch February 15, 2017 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants