Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix users missing in search results when sending tokens #3646

Merged
merged 6 commits into from
Apr 8, 2023

Conversation

wentokay
Copy link
Collaborator

@wentokay wentokay commented Apr 8, 2023

fixes #3645

  • re-adds public_keys.publicKey and adds some tests to make refactoring possible if we choose to stick to a convention of snake case or camel case for data served from the API
  • merges return exact username match as first result when searching for users #3641 which returns the exact username match as the first result
  • adds & before limit url search param so blockchain=solanalimit=6 becomes blockchain=solana&limit=6

@vercel
Copy link

vercel bot commented Apr 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
backpack ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 8, 2023 11:01am

@github-actions github-actions bot added the backend Related to backend infra, reef or cf workers label Apr 8, 2023
@wentokay wentokay changed the title fix users missing in search results fix users missing in search results when sending tokens Apr 8, 2023
@wentokay wentokay marked this pull request as ready for review April 8, 2023 11:21
@wentokay wentokay merged commit 77bffbb into master Apr 8, 2023
@wentokay wentokay deleted the wen/fix-users-not-showing-in-list branch April 8, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to backend infra, reef or cf workers extension mobile Related to expo mobile app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression with backpack usernames showing up for send list and send view
1 participant