Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use auth_users.public_keys.is_primary in all relevant queries #3589

Merged
merged 4 commits into from
Apr 7, 2023

Conversation

wentokay
Copy link
Collaborator

@wentokay wentokay commented Apr 4, 2023

uses public_keys.is_primary to use the db indexes when checking if public keys are primary or not

added tests for all the endpoints it might affect, to try and ensure it doesn't introduce any regression bugs. These could probably be reduced or removed eventually if we added something like zod and trpc to our api endpoints for typing guarantees

also adds redis in docker-compose so that xnft-api-server can be run locally

@vercel
Copy link

vercel bot commented Apr 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
backpack ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 7, 2023 9:04am

@github-actions github-actions bot added the backend Related to backend infra, reef or cf workers label Apr 4, 2023
@socket-security
Copy link

socket-security bot commented Apr 4, 2023

No dependency changes detected. Learn more about Socket for GitHub ↗︎


👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

⚠️ Please accept the latest app permissions to ensure bot commands work properly. Accept the new permissions here.

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

@wentokay wentokay force-pushed the wen/more_public_keys_is_primary branch from e6a4988 to 21757f0 Compare April 4, 2023 16:14
@wentokay wentokay force-pushed the wen/more_public_keys_is_primary branch from 21757f0 to 354ed65 Compare April 6, 2023 15:45
@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2023

yarn.lock changes

Summary

Status Count
ADDED 26
UPDATED 4
Click to toggle table visibility
Name Status Previous Current
@types/chai-subset ADDED - 1.3.3
@vitest/expect ADDED - 0.29.8
@vitest/runner ADDED - 0.29.8
@vitest/spy ADDED - 0.29.8
@vitest/utils ADDED - 0.29.8
cac ADDED - 6.7.14
chai UPDATED 4.3.4 4.3.7
deep-eql UPDATED 3.0.1 4.1.3
diff ADDED - 5.1.0
jsonc-parser ADDED - 3.2.0
local-pkg ADDED - 0.4.3
loupe ADDED - 2.3.6
mlly ADDED - 1.2.0
p-limit UPDATED 3.1.0 4.0.0
pathe ADDED - 1.1.0
pkg-types ADDED - 1.0.2
rollup ADDED - 3.20.2
siginfo ADDED - 2.0.0
stackback ADDED - 0.0.2
std-env ADDED - 3.3.2
strip-literal ADDED - 1.0.1
tinybench ADDED - 2.4.0
tinypool ADDED - 0.4.0
tinyspy ADDED - 1.1.1
ufo ADDED - 1.1.1
vite-node ADDED - 0.29.8
vite ADDED - 4.2.1
vitest ADDED - 0.29.8
why-is-node-running ADDED - 2.2.2
yocto-queue UPDATED 0.1.0 1.0.0

@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2023

🤖 Hasura Change Summary compared a subset of table metadata including permissions:

Updated Tables (1)

  • default.auth.users permissions:

    insert select update delete
    auth_worker /
    1 added column permissions
    insert select update
    auth_worker ➕ id

wentokay added 4 commits April 7, 2023 10:03
add some backend tests, add redis locally, update hasura and add healthcheck, let auth worker insert auth_users.id
@wentokay wentokay force-pushed the wen/more_public_keys_is_primary branch from fdff977 to 09c1c77 Compare April 7, 2023 09:03
@wentokay wentokay marked this pull request as ready for review April 7, 2023 11:55
@wentokay wentokay merged commit 7d51e40 into master Apr 7, 2023
@wentokay wentokay deleted the wen/more_public_keys_is_primary branch April 7, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to backend infra, reef or cf workers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant