Issue 387 remplacing links by icons #546

Malmousque · 2019-03-06T14:54:25Z

This PR replaces links, particulary in tabs, by icons into the 5 modules, some icons was already in use in some place, the idea is to improve and make the UX coherent.

5 news CSS classes have been added : .removeIcon .editIcon .updateIcon .addIcon .addIconTab.
All the icons was already in use. Most of them was only in the Resources modules images folder, I add them in the others images folders.

To update

To add

To remove

To edit

Is the update and edit function have a real separate function ?

3.0.1

…ere is already icons for modifying/delete. The most of changes are in ressources/ajax_htmldata folder, 3 news css class (style.css) : div.ImportElement, div.addElement, div.adminHeader, with flexbox

…licensing, usage modules. Most of the changes in the ajax_HTMLdata and ajax_forms and admin file. News css classes : editIcon, AddIcon...

…ax_htmldata files and cataloging.php

…. The ajax_htmldata files of the licensing, organizations, resources and usage modules have been amended, the css classes addIcon,adminAddIcon, removeIcone, AdminRemoveIcon, editIcon, adminEditIcon, adminUploadIcon and alignIcon have been created. alignIcon uses flexbox. Some links remain for a better understanding of users.

…. The ajax_htmldata files of the licensing, organizations, resources and usage modules have been amended, the css classes addIcon,adminAddIcon, removeIcone, AdminRemoveIcon, editIcon, adminEditIcon, adminUploadIcon and alignIcon have been created. alignIcon uses flexbox. Some links remain for a better understanding of users. Update(the 05 march 19) : add icons in the management module

… and fix css in licensing and management

veggiematts · 2019-03-06T15:16:02Z

licensing/ajax_htmldata.php

@@ -203,7 +203,7 @@
 				echo "<td><div id='attachment_short_" . $attachment->attachmentID . "'>" . substr($attachmentText, 0,200);

 				if (strlen($attachmentText) > 200){
-					echo "...&nbsp;&nbsp;<a href='javascript:showFullAttachmentText(\"" . $attachment->attachmentID . "\");'>"._("more...")."</a>";
+					echo "...&nbsp;&nbsp;<a href='javascript:showFullAtt		break;achmentText(\"" . $attachment->attachmentID . "\");'>"._("more...")."</a>";


veggiematts · 2019-03-06T15:18:54Z

licensing/js/admin.js

@@ -354,7 +354,7 @@ function submitQualifier(){


 function showAdd(tableName){
-       $('#span_new' + tableName).html("<input type='text' name='new" + tableName + "' id='new" + tableName + "' class='adminAddInput' />  <a href='javascript:addData(\"" + tableName + "\");'>"+_("add")+"</a>");
+       $('#span_new' + tableName).html("<input type='text' name='new" + tableName + "' id='new" + tableName + "' class='adminAddInput' />  <a href='javascript:addData(\"" + tableName + "\");'><img id='addCurrency' src='images/plus.gif' title='add' /></a>");


Translation

veggiematts · 2019-03-06T15:22:20Z

resources/ajax_htmldata/getAccessDetails.php

-					<a href='ajax_forms.php?action=getNoteForm&height=233&width=410&tab=Access&entityID=<?php echo $resourceAcquisitionID; ?>&resourceNoteID=&modal=true' class='thickbox'><?php echo _("add new note");?></a>
+				<a href='ajax_forms.php?action=getNoteForm&height=233&width=410&tab=Access&entityID=<?php echo $resourceAcquisitionID; ?>&resourceNoteID=&modal=true' class='thickbox'><?php echo "<div class= 'addIconTab'><img id='Add' class='addIcon' src='images/plus.gif' title= '"._("Add")."' /></div>";?></a>
+				<?php }
+				if ($user->canEdit()){?>


This seems misplaced.

veggiematts · 2019-03-06T15:23:58Z

resources/ajax_htmldata/getAdminAlertDisplay.php

+		?>
+		<div class="adminHeader">
+			<div></div>
+			<div class="addElement" style= "padding-bottom: 8px;"><?php echo "<a href='ajax_forms.php?action=getAdminAlertDaysForm&alertDaysInAdvanceID=&height=128&width=260&modal=true' class='thickbox'><img id='addAlertDay' src='images/plus.gif' title='add day'/></a>";?></div>


Translation

veggiematts · 2019-03-06T15:25:14Z

resources/ajax_htmldata/getAdminUserDisplay.php

 			<div class="adminRightHeader"><?php echo _("Users");?></div>
+			<div class="addElement" style="margin-right: 4px"><a href='ajax_forms.php?action=getAdminUserUpdateForm&loginID=&height=275&width=315&modal=true' class='thickbox' id='addUser'><img id='addUserGroup' src='images/plus.gif' title='add User' /></a></div>


Translation

veggiematts · 2019-03-06T15:26:42Z

resources/ajax_htmldata/getProductDetails.php

 				<?php if ($user->canEdit()){ ?>
-					<a href='ajax_forms.php?action=getNoteForm&height=233&width=410&tab=Product&entityID=<?php echo $resourceID; ?>&resourceNoteID=&modal=true' class='thickbox'><?php echo _("add new note");?></a>
+					<a href='ajax_forms.php?action=getNoteForm&height=233&width=410&tab=Product&entityID=<?php echo $resourceID; ?>&resourceNoteID=&modal=true' class='thickbox'><?php echo "<div class='addIconTab' ><img id='Add' src='images/plus.gif' title= '"._("Add")."' /></div>";?></a></div>
+					<?php if ($user->canEdit()){ ?>


This seems misplaced

…l issues : translation in licensing/js/admin and misplacing in resources/ajax_htmldata/getProductsDetails.php

…resources/ajax_htmldata/getProductsDetails

LibClaire · 2019-03-08T11:37:27Z

Hi,
I've just had a first look at this. Patch applies without a problem and the icons are working as links.

I have a couple of comments:

Resources module: it would be nice if the "add" icon appeared next to the headings as it does in the other modules. I think it reads better that way and it is clearer what the icon is for.
Resources module: Under admin - alert settings there are two "add" icons, one for "add email" and one for "add day", it might be a good idea to have some text here to help identify them. (I have seen the title hover text, which is good, but I don't think it is enough when there is more than one option)
Licensing module: we have two different options, update and edit. My personal opinion is that we don't need to have two different icons/definitions here as they do the same thing? I came across this recently while translating and I think "edit" would be enough for all cases. Happy to have further feedback on this, perhaps there was a use case for it.

Otherwise I think this is good! I like the icons. :)

…text identify add icon for email and add icon for day under admin -alert setting ressources module

Malmousque · 2019-03-14T14:36:18Z

Hi,
Sorry for not answering faster. The "add" icon now appears next to the headings in the ressource module, and I have added text to identify "add" icon in alert settings.
It would be maybe better to keep the question of "update/edit" for a next issue.
Thank you for your recommendations. :)

veggiematts · 2019-03-14T14:43:09Z

resources/ajax_htmldata/getAdminAlertDisplay.php

-			<div></div>
-			<div class="addElement" style= "padding-bottom: 8px;"><?php echo "<a href='ajax_forms.php?action=getAdminAlertDaysForm&alertDaysInAdvanceID=&height=128&width=260&modal=true' class='thickbox'><img id='addAlertDay' src='images/plus.gif' title='"._("add day")."'/></a>";?></div>
+			</div>
+			<div class="addElement" style= "padding-bottom: 8px;"><?php echo "<div><span class= 'addIconAlert'>Add a day: &nbsp;</span><a href='ajax_forms.php?action=getAdminAlertDaysForm&alertDaysInAdvanceID=&height=128&width=260&modal=true' class='thickbox'><img id='addAlertDay' src='images/plus.gif' title='"._("add day")."'/></a></div>";?></div>


Translation

veggiematts · 2019-03-14T14:43:41Z

resources/ajax_htmldata/getAdminAlertDisplay.php

-		<div class="addElement"><?php echo "<a href='ajax_forms.php?action=getAdminAlertEmailForm&alertEmailAddressID=&height=128&width=260&modal=true' class='thickbox'><img id='addAlertEmail' src='images/plus.gif' title='"._("add Email")."' /></a>";?></div>
+		<div class="adminHeaderAlert">
+		<?php echo "<div class='adminRightHeader'>"._("Alert Settings")."</div><br>";?>
+		<div class="addElement"><?php echo "<div><span class= 'addIconAlert'>Add an email: &nbsp;</span><a href='ajax_forms.php?action=getAdminAlertEmailForm&alertEmailAddressID=&height=128&width=260&modal=true' class='thickbox'><img id='addAlertEmail' src='images/plus.gif' title='"._("add Email")."' /></a></div>";?></div></br>


Translation

…s module can now be translated

Malmousque · 2019-03-14T15:05:59Z

"Add an email" and "Add a day" in the alert settings / ressources module can, now, be translated.

LibClaire · 2019-03-25T10:22:46Z

Hi Malmousque,
the changes look great!
I only have one other comment/question
Funds: here we have the 'down arrow' for an import. I am wondering if it is immediately clear what the icon means? To me an 'up arrow' would make more sense for an import and a 'down arrow' for download, but I know we have that in the other modules as 'update'... maybe we can address it in a new pull request but I wanted to flag it as possibly confusing.

Malmousque · 2019-03-25T10:44:58Z

Hi LibClaire,

I'm agree with you. For now, I have done with the icons provided with coral, but we could use others. I will talk about that with matts.

veggiematts · 2019-03-28T10:50:14Z

I think we can safely merge 'update' and 'edit' buttons to only have 'edit'.
I think having both wasn't made on purpose, but comes from development. We have two types of tables for admin preferences: standard and custom ones. All the standard ones use 'edit', and some of the custom ones use 'update'. We should make this consistent and only keep 'edit'.

PaulPoulain · 2019-03-28T12:39:18Z

++ for merging update & edit and thus be consistent !

LibClaire · 2019-03-28T12:58:02Z

I would agree to just having 'edit'. I think it will be cleaner that way

…ns are center in the tab cells

LibClaire · 2019-03-29T11:12:21Z

Hi,
everything is looking good. The import icon is better!
One last comment. When going to edit something in a module that isn't resources, the heading of the pop up is still 'update'. Do we want to change the wording so that it is consistent?

Malmousque · 2019-03-29T11:21:22Z

Hi LibClaire,

Yes, of course, I had to miss some "update".
Thanks

Malmousque · 2019-03-29T12:48:31Z

Hi,
Sorry Claire, but I can't find the pop up you're talking about. All the 'Edit' icons seem to have an 'Edit' pop up. Could you tell me where it is ?

veggiematts · 2019-03-29T12:53:55Z

Editing users in licensing for instance:

It should be "Edit user"

…n of the buttons titles

Malmousque · 2019-03-29T15:43:41Z

I modified the titles of the windows and harmonized the titles of the buttons (because for some, the title of the button and the window was in the same variable).
Have a nice WE !

This reverts commit 3229d41.

LibClaire · 2019-04-01T09:44:17Z

Hi Malmousque,
I think it looks good now. :)

veggiematts · 2019-04-03T12:21:54Z

Merging this to devel. Thank you @LibClaire and @Malmousque for the good work!

jeffnm and others added 9 commits February 14, 2019 09:19

Merge pull request coral-erm#539 from coral-erm/development

528fa17

3.0.1

The issue 387 proposed to add icons replacing the 'add' links when th…

91cac09

…ere is already icons for modifying/delete. The most of changes are in ressources/ajax_htmldata folder, 3 news css class (style.css) : div.ImportElement, div.addElement, div.adminHeader, with flexbox

add css class : div.ImportElement, div.addElement, div.adminHeader

01d57a5

Adding icons : add, update, edit, remove in organization, resources, …

1b61b76

…licensing, usage modules. Most of the changes in the ajax_HTMLdata and ajax_forms and admin file. News css classes : editIcon, AddIcon...

Icon align modifications in licensing, organizations and resources aj…

16ab20d

…ax_htmldata files and cataloging.php

Fix bugs : some icons was inactives in resource module. Adding icones…

3f625e8

… and fix css in licensing and management

veggiematts added ux Related to User Experience enhancement This is an enhancement (not a bug) labels Mar 6, 2019

veggiematts requested changes Mar 6, 2019

View reviewed changes

Malmousque added 2 commits March 7, 2019 11:12

Fix translation, typo and misplacing mentionned in PR, there is stil…

60fc3b7

…l issues : translation in licensing/js/admin and misplacing in resources/ajax_htmldata/getProductsDetails.php

Fix translation issue in licensing/js/admin.js and misplaced line in …

d022591

…resources/ajax_htmldata/getProductsDetails

veggiematts approved these changes Mar 8, 2019

View reviewed changes

In the ressource module the add icon appearsnext to the headings and …

c22c091

…text identify add icon for email and add icon for day under admin -alert setting ressources module

veggiematts requested changes Mar 14, 2019

View reviewed changes

The 'add an email' and the 'add day' text in alert settings ressource…

7b7945c

…s module can now be translated

veggiematts approved these changes Mar 14, 2019

View reviewed changes

Malmousque added 3 commits March 28, 2019 16:09

Remplacing the 'Update' by 'Edit' as well as corresponding icons, ico…

fc48a3e

…ns are center in the tab cells

New 'import fund' icon in resources -admin

a589926

Change 'import fund' black icon to color

24a739e

delete icons .svg and blue

9bd7dba

Change the 'Upload' title of pop up windows into 'Edit', harmonizatio…

b678414

…n of the buttons titles

Revert "Update footer in preparation for release."

ae0583e

This reverts commit 3229d41.

veggiematts merged commit 4a2bfb4 into coral-erm:development Apr 3, 2019

veggiematts mentioned this pull request Apr 3, 2019

Use an icon for Add/Create/New #387

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Issue 387 remplacing links by icons #546

Issue 387 remplacing links by icons #546

Malmousque commented Mar 6, 2019 •

edited by veggiematts

Loading

veggiematts Mar 6, 2019

veggiematts Mar 6, 2019

veggiematts Mar 6, 2019

veggiematts Mar 6, 2019

veggiematts Mar 6, 2019

veggiematts Mar 6, 2019

LibClaire commented Mar 8, 2019

Malmousque commented Mar 14, 2019

veggiematts Mar 14, 2019

veggiematts Mar 14, 2019

Malmousque commented Mar 14, 2019

LibClaire commented Mar 25, 2019

Malmousque commented Mar 25, 2019

veggiematts commented Mar 28, 2019

PaulPoulain commented Mar 28, 2019

LibClaire commented Mar 28, 2019

LibClaire commented Mar 29, 2019

Malmousque commented Mar 29, 2019

Malmousque commented Mar 29, 2019

veggiematts commented Mar 29, 2019

Malmousque commented Mar 29, 2019

LibClaire commented Apr 1, 2019

veggiematts commented Apr 3, 2019

		<div class="adminRightHeader"><?php echo _("Users");?></div>
		<div class="addElement" style="margin-right: 4px"><a href='ajax_forms.php?action=getAdminUserUpdateForm&loginID=&height=275&width=315&modal=true' class='thickbox' id='addUser'><img id='addUserGroup' src='images/plus.gif' title='add User' /></a></div>

Issue 387 remplacing links by icons #546

Issue 387 remplacing links by icons #546

Conversation

Malmousque commented Mar 6, 2019 • edited by veggiematts Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

LibClaire commented Mar 8, 2019

Malmousque commented Mar 14, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Malmousque commented Mar 14, 2019

LibClaire commented Mar 25, 2019

Malmousque commented Mar 25, 2019

veggiematts commented Mar 28, 2019

PaulPoulain commented Mar 28, 2019

LibClaire commented Mar 28, 2019

LibClaire commented Mar 29, 2019

Malmousque commented Mar 29, 2019

Malmousque commented Mar 29, 2019

veggiematts commented Mar 29, 2019

Malmousque commented Mar 29, 2019

LibClaire commented Apr 1, 2019

veggiematts commented Apr 3, 2019

Malmousque commented Mar 6, 2019 •

edited by veggiematts

Loading