Pr4iss15.17: Add enhanced cost history new fields to export and print view #43
Conversation
…e fields in Cost History
fondrenlibrary
force-pushed
the
pr4iss15.17
branch
from
c2dc731 to
13aa847
Compare
|
Will wait for Sirsi' s upcoming merge which might affect the fund code field and then make some corresponding updates to this PR if necessary. Also waiting for PR #3 to be committed first. |
remocrevo
changed the title
| @@ -283,3 +282,40 @@ function postwith (to,p) { | |||
| document.body.removeChild(myForm) ; | |||
| } | |||
|
|
|||
|
|
|||
| function isValidDate(dateString) | |||
There was a problem hiding this comment.
Instead of writing our own date validation code, we should consider using jQuery. Note: CORAL currently uses jQuery 1.4.4. Here is an example:
http://stackoverflow.com/questions/6598386/jquery-validation-date
There was a problem hiding this comment.
Yes, it's really handy and better to use JQuery/Plugin, however at the time when this PR was being written, the version of jQuery was found really behind. Now, after pulling all latest commits into this PR, I decide to completely give up date validation because Subscription dates still look not required and the underlying mySQL can automatically reset all invalid date inputs to 01/01/1970 after they are are submitted and later they can be changed at any time to good ones.
There was a problem hiding this comment.
After sync'd with the master branch and conflict resolving done, this PR can be tested again and ready to merge (before or after #63) . The following changes have been made to the original PR.
- Date validation dropped.
- Extra cost fields in the Cost column in "exported" CSV dropped. If later better idea can be acquired about how to present all cost fields in the Cost column, a new PR can be created.
- An issue with submission of Cost Form by costForm.js fixed. This issue has been introduced since a major commit in June
There was a problem hiding this comment.
Note: CORAL currently uses jQuery 1.4.4.
Actually Coral uses 4 different versions of jQuery so we have a broad choice ! ^^"
There was a problem hiding this comment.
@remocrevo , nowadays it seems hard to find a working validation plugin for jquery 1.4.4 which is loaded by the Resource pages. On the other hand, the newest validation plugin can't handle leap years well as opposed to the validateDate() function added by this PR a while ago, though this is not a game changer at all. Maybe we also need to discuss jQuery versions in the upcoming SC meeting. For now, as mentioned in my early comment, I completely drop out the date validation function and we can re-add it later on separately. By the way, would you mind testing and merging this PR before this PR becomes conflicting again? Any direct editing and committing upon problems found is welcome. Thank you.
There was a problem hiding this comment.
By the way, would you mind testing and merging this PR before this PR becomes conflicting again?
Is there a test plan (instructions to setup and test) somewhere? So anyone could test it even without having followed this PR.
There was a problem hiding this comment.
@tuxayo , actually, no particular test plan nor any integration test plan. The only test by hand plan is set enhancedCostHistory=Y and watch whether all the enhanced fields can show up in Edit Cost Information and then watch whether Cost information can be saved. Also we need to observe whether those enhanced fields show in Print View which is under the Helpful Links. An extra benefit but not planned is this PR has fixed the error encountered upon saving Cost history. @tuxayo if your test proves fine to you, simply merge it. Thank you.
There was a problem hiding this comment.
actually, no particular test plan nor any integration test plan. The only test by hand plan is [...]
Maybe test plan weren't the right words but yes I meant manual instructions to be able to check that this PR works as intended without prior knowledge. So I (or others) could manually test it and contribute to build enough confidence so it could be merged quicker.
Thanks, the instructions that you provided are exactly what I needed. I hope to have the time to try them.
… text fields used to accept dates about Resource
…ues can be correctly captured and saved after costForm.js is modified to only allow selecting tax fields in .paymentTable TR (table row)
|
SC approved is assigned and ready to be merged (next week). |
Used to solve issue #15 and #17 plus add basic date validity check to the date fields in cost history.