-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt w.r.t coq/coq#20167. #1023
Conversation
I'm not sure why the CI is still broken here, but it should really be backwards compatible, I tested it locally. |
The CI for master seems to have issues with the stdlib split or renaming
CI for <9.0 correctly says
|
What is Tok.equal then, and why it is called like that? |
@gares it was introduced for backward compatibility with camlp4 quite a long time ago, and this IDENT ≤ KEYWORD rule was added to work around the fact that an indent could be turned at any point into a keyword. So that's a plain hack. |
Anyone merging this? |
This branch has conflicts that must be resolved |
Rebased. |
You still have the non exhaustive match issue on older Coq versions |
Hopefully this does not trigger warnings or something. |
This is backwards compatible.
I copied the function here because Tok.equal in Coq is actually not the equality function, there is special-casing of KEYWORD and IDENT that used to be there to support a hack in the parser.