Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Document the context hook extension #641

Merged
merged 13 commits into from
Apr 24, 2022
Merged

docs: Document the context hook extension #641

merged 13 commits into from
Apr 24, 2022

Conversation

pawamoy
Copy link
Contributor

@pawamoy pawamoy commented Apr 14, 2022 •
edited
Loading

Closes issue #629.

@yajo yajo linked an issue Apr 15, 2022 that may be closed by this pull request
Internal keys / non-prompted values #629
Closed
yajo
yajo reviewed Apr 15, 2022
View reviewed changes
Copy link
Member

@yajo yajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems you have to run pre-commit to fix the builds

@codecov-commenter
Copy link

codecov-commenter commented Apr 15, 2022 •
edited
Loading

Codecov Report

Merging #641 (4c370de) into master (23dd5db) will increase coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #641      +/-   ##
==========================================
+ Coverage   96.46%   96.55%   +0.09%     
==========================================
  Files          41       41              
  Lines        2800     2847      +47     
==========================================
+ Hits         2701     2749      +48     
+ Misses         99       98       -1
Flag Coverage Δ
unittests 96.55% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
copier/main.py 94.42% <0.00%> (ø)
tests/test_updatediff.py 100.00% <0.00%> (ø)
tests/test_complex_questions.py 100.00% <0.00%> (ø)
tests/demo/config.py.tmpl 100.00% <0.00%> (+33.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23dd5db...4c370de. Read the comment docs.

yajo
yajo approved these changes Apr 20, 2022
View reviewed changes
@yajo yajo enabled auto-merge (squash) April 20, 2022 11:10
@pawamoy
Copy link
Contributor Author

pawamoy commented Apr 20, 2022

Please do squash commits when merging 🙂

verdaatt
verdaatt reviewed Apr 21, 2022
View reviewed changes
Copy link
Contributor

@verdaatt verdaatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Couple of small suggestions

@yajo yajo disabled auto-merge April 23, 2022 06:50
@pawamoy
Copy link
Contributor Author

pawamoy commented Apr 24, 2022

Suggestions applied! Thanks @verdaatt

@yajo yajo merged commit 945238b into copier-org:master Apr 24, 2022
@pawamoy pawamoy deleted the docs-augmenting-context branch April 2, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@verdaatt verdaatt verdaatt left review comments

@yajo yajo yajo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Internal keys / non-prompted values
4 participants
@pawamoy @codecov-commenter @yajo @verdaatt