Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pydantic): add upper dependency bound to fix unlocked installations #1244

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

yajo
Copy link
Member

@yajo yajo commented Jul 10, 2023

Fix #1225.

@yajo
Copy link
Member Author

yajo commented Jul 10, 2023

@copier-org/maintainers do you see this as a good temporary fix while we settle #1229?

These months I'll have reduced availability to work on Copier, so I think going for the MVP is a good idea.

@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Merging #1244 (77741a6) into master (a5da81c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1244   +/-   ##
=======================================
  Coverage   96.75%   96.75%           
=======================================
  Files          47       47           
  Lines        3942     3942           
=======================================
  Hits         3814     3814           
  Misses        128      128           
Flag Coverage Δ
unittests 96.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@sisp sisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with it. We can move on to Pydantic v2 shortly afterwards. If @pawamoy doesn't have the capacity to finish #1229, I can take over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pydantic 2.0 (complete rewrite) breaks copier
2 participants