Fix : wrong value in VolumeUnits steps when creating a new rule #4889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladimir-8
requested changes
Feb 10, 2025
|
|
||
| const newUnit = e.target.value | ||
|
|
||
| if (newUnit === 'vu') { |
There was a problem hiding this comment.
There is a bug if the switch is between units that are both multiplied (kg, km); it needs an extra check that the current unit is 1000x (kg, km) and the newUnit is not (vu), and vice versa:
There was a problem hiding this comment.
May be add a helper to check if a unit is multiplied or not instead of hard-coding 'vu' to allow adding more units
There was a problem hiding this comment.
I think it should be refactored at a "higher level" to remove all these multiplication/division from the component, and just multiply by *1000 in the change handler if it kg/km
let's do that later when we have more time, knowing that the price screen is soon to be refactored
vladimir-8
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.