Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3597 allow reordering tasks of a tour #3635

Merged
merged 13 commits into from
Jun 28, 2023

Conversation

jimakker
Copy link

@jimakker jimakker commented May 10, 2023

Fixes #3597
Fixes #3552
See #3595

@jimakker jimakker linked an issue May 10, 2023 that may be closed by this pull request
3 tasks
@jimakker jimakker marked this pull request as ready for review June 14, 2023 17:21
@jimakker jimakker requested review from alexsegura and r0xsh June 14, 2023 17:22
@jimakker
Copy link
Author

We have:

  • third panel: unassigned Tours
  • reorder tasks in unassigned Tour
  • d-n-d assign tasks to unassigned Tour
  • remove task from unassigned Tour
  • unassign Tour from rider

Thx for reviewing, all comments welcome ❤️

@alexsegura alexsegura force-pushed the 3597-allow-reordering-tasks-of-a-tour branch from d344db3 to c6e1637 Compare June 27, 2023 12:34
@alexsegura alexsegura force-pushed the 3597-allow-reordering-tasks-of-a-tour branch from c6e1637 to 9f2162b Compare June 27, 2023 12:40
Comment on lines +17 to +18
export const enableUnassignedToursDroppable = createAction(ENABLE_UNASSIGNED_TOURS_DROPPABLE)
export const disableUnassignedToursDroppable = createAction(DISABLE_UNASSIGNED_TOURS_DROPPABLE)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be never called.

Copy link
Member

@alexsegura alexsegura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a task to a tour does not work.

tours_bug

Copy link
Member

@alexsegura alexsegura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ok now.

tours_ok

@alexsegura alexsegura merged commit 32e571a into master Jun 28, 2023
@alexsegura alexsegura deleted the 3597-allow-reordering-tasks-of-a-tour branch June 28, 2023 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow reordering tasks of a tour before assigning it Improving the "tour" concept
2 participants