Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MUC occupants badges: displays short labels, with full label as title. #3498

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

JohnXLivingston
Copy link
Contributor

By default, we take the first letter of all badge, and only display this letter (full badge name is set as title and aria-label for screen readers). If there is ambiguous letters, we use 2 (or 3, ... up to 4) letters.

image

  • Add a changelog entry for your change in CHANGES.md
  • When adding a configuration variable, please make sure to
    document it in docs/source/configuration.rst
  • Please add a test for your change. Tests can be run in the commandline
    with make check or you can run them in the browser by running make serve
    and then opening http://localhost:8000/tests.html.

@JohnXLivingston
Copy link
Contributor Author

Tests failed on the CI, but seems not related to my PR. Tests are ok on my computer.

@jcbrand
Copy link
Member

jcbrand commented Sep 4, 2024

Tests failed on the CI, but seems not related to my PR. Tests are ok on my computer.

If you rebase on to the master branch then this should be fixed.

@jcbrand jcbrand merged commit 16d941a into master Sep 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants