-
Notifications
You must be signed in to change notification settings - Fork 922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: subject-full-stop doesn't work if type contains dot #3530
Labels
Comments
tehraninasab
added a commit
to tehraninasab/commitlint
that referenced
this issue
Feb 12, 2023
tehraninasab
added a commit
to tehraninasab/commitlint
that referenced
this issue
Feb 13, 2023
escapedcat
pushed a commit
that referenced
this issue
Feb 13, 2023
* test(subject-full-stop): add two tests * fix: subject-full-stop rule bugfix Fixes #3530
knocte
added a commit
to nblockchain/conventions
that referenced
this issue
Feb 14, 2023
This rule was most of the time not working for us before, because of an upstream bug[1] which we have now fixed [2]. Given that a recent commit[3] upgraded our version of commitlint, we can just add integration tests now and we are done. [1] conventional-changelog/commitlint#3530 [2] conventional-changelog/commitlint#3531 [3] 1975174
knocte
added a commit
to nblockchain/conventions
that referenced
this issue
Feb 14, 2023
This rule was most of the time not working for us before, because of an upstream bug[1] which we have now fixed [2]. Given that a recent commit[3] upgraded our version of commitlint, we can just add integration tests now and we are done. [1] conventional-changelog/commitlint#3530 [2] conventional-changelog/commitlint#3531 [3] 1975174
knocte
added a commit
to nblockchain/conventions
that referenced
this issue
Feb 14, 2023
This rule was most of the time not working for us before, because of an upstream bug[1] which we have now fixed [2]. Given that a recent commit[3] upgraded our version of commitlint, we can just add integration tests now and we are done. [1] conventional-changelog/commitlint#3530 [2] conventional-changelog/commitlint#3531 [3] 1975174 Co-authored-by: Zahra TehraniNasab <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected Behavior
subject-full-stop should flag commit msg as wrong.
Current Behavior
subject-full-stop considers commit msg as fine.
Affected packages
Possible Solution
No response
Steps to Reproduce
Context
No response
commitlint --version
17.0.0
git --version
2.34.1
node --version
12.22.9
The text was updated successfully, but these errors were encountered: