Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pass ansible extra args properly to ansible #308

Merged
merged 2 commits into from
Nov 22, 2017
Merged

pass ansible extra args properly to ansible #308

merged 2 commits into from
Nov 22, 2017

Conversation

chrisplo
Copy link
Contributor

Signed-off-by: Chris Plock [email protected]

@chrisplo chrisplo force-pushed the fix_ans_args branch 4 times, most recently from c13ded2 to 197e2f0 Compare November 18, 2017 04:41
@chrisplo
Copy link
Contributor Author

build PR

@chrisplo chrisplo force-pushed the fix_ans_args branch 2 times, most recently from 315f6ab to 725b108 Compare November 20, 2017 23:07
@chrisplo chrisplo changed the title WIP: pass ansible extra args properly to ansible pass ansible extra args properly to ansible Nov 20, 2017
@chrisplo
Copy link
Contributor Author

example with local socks5 proxy ssh -D 1080 localhost:

./install/ansible/install_swarm.sh -a "-v --ssh-common-args=\"-o ProxyCommand='nc -x 192.168.2.1 %h %p'\"" -f ../../cluster/.cfg_swarm-mode.yaml -u vagrant -e /Users/chrisplo/.vagrant.d/insecure_private_key -p

@chrisplo chrisplo force-pushed the fix_ans_args branch 2 times, most recently from 45b28a0 to 4888429 Compare November 20, 2017 23:32
@chrisplo
Copy link
Contributor Author

tested with:

CONTIV_ANSIBLE_IMAGE=plockc/contiv-install:1.1.7.2 BUILD_VERSION=devbuild make build demo-swarm-mode

@chrisplo
pass ansible extra args properly to ansible
34e1ff1 
Drive-by: allow for environment override of the installer image to
demonstate a working install in CI, in the future the build process
can build inline for for CI purposes and add that image to the full
installer as well.

Drive-by: update assets to 1.1.7 by default

Signed-off-by: Chris Plock <[email protected]>
@chrisplo
Copy link
Contributor Author

build PR

@chrisplo
Copy link
Contributor Author

this should address: https://github.com/contiv/ccn/issues/402

tiewei
tiewei approved these changes Nov 22, 2017
View reviewed changes
Copy link
Contributor

@tiewei tiewei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chrisplo chrisplo merged commit 83adf9a into contiv:master Nov 22, 2017
@chrisplo chrisplo deleted the fix_ans_args branch November 22, 2017 00:50
@blaksmit blaksmit mentioned this pull request Nov 22, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dseevr dseevr dseevr approved these changes

@tiewei tiewei tiewei approved these changes

Assignees
No one assigned
Labels
squash merge only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chrisplo @dseevr @tiewei