cluster/Vagrantfile: pin box version & add var #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisplo
reviewed
Nov 8, 2017
cluster/Vagrantfile
Outdated
| @@ -11,6 +11,7 @@ UBUNTU = 'ubuntu'.freeze | |||
| CENTOS = 'centos'.freeze | |||
| RHEL = 'rhel7'.freeze | |||
|
|
|||
| BOX_VERSION= ENV['BOX_VERSION'] || '1707.01' | |||
There was a problem hiding this comment.
not a blocker and I am not a ruby guy, but the other assignments have a space before '='
There was a problem hiding this comment.
Haha, yeah there should be a space here for consistency reasons even though this is still valid Ruby. Maybe also throw a .freeze on the end of the string literal too
tiewei
approved these changes
Nov 8, 2017
Signed-off-by: Cristian Staretu <[email protected]>
dseevr
approved these changes
Nov 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pins the Vagrant box to the last known Vagrant box which didn't have a kernel with compressed kernel modules. This is a temporary solution to the compressed kernel module issue.
The environment variable makes it possible to override this as needed. This PR is required to sort out the issues with the CI.