-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds additional query syntax for the CDA #49
Adds additional query syntax for the CDA #49
Conversation
Pull Request Test Coverage Report for Build 8903f5c601181890f9d8e199d75cc7b270af06b7-PR-49Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
44e140f
to
8903f5c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks quite good. I'm not a query expert though. 😅
Just tiny nits.
for easier tdd
Removes configuration into it's own module, also moves request related functions into it's own `Contentful.Request` module.
Co-authored-by: Christoph Grabo <[email protected]>
Co-authored-by: Christoph Grabo <[email protected]>
c1d7dd3
to
7fa67f1
Compare
..as part of actually writing the officially recognized X-Contentful-User-Agent Header
as proposed by @asaaki
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love it! 😍
After having no time for a while these days and thinking a bit about #38, I decided to put in some work about it.
This will add support for more complex queries as noted by @ryansch, in the form of:
and provide some safeguards around it, e.g. using
by
without acontent_type
call is not permitted, etc.Feedback, as always, is very welcome.
TODO
content_type
by
by
, via[nin]
and[in]
by
via[lte]
,[gte]
,[lt]
and[gt]
query
and[match]
Out of scope
Somebody create some issues for the ones above please 😉 (will probably do tomorrow)
Fixes #38.