Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(build): fresh clones build again due to dependency upgrade #126

Merged
merged 1 commit into from
Jun 30, 2020
Merged

fix(build): fresh clones build again due to dependency upgrade #126

merged 1 commit into from
Jun 30, 2020

Conversation

axe312ger
Copy link
Contributor

@axe312ger axe312ger requested a review from jo-sm June 23, 2020 10:27
@axe312ger axe312ger changed the title fix(build): fresh closes build again due to dependency upgrade fix(build): fresh clones build again due to dependency upgrade Jun 23, 2020
@axe312ger axe312ger mentioned this pull request Jun 23, 2020
Closed
@axe312ger axe312ger force-pushed the fix/upgrade-dependencies branch from b61f593 to 1211b43 Compare June 23, 2020 10:33
This was referenced Jun 23, 2020
Closed
Closed
jo-sm
jo-sm approved these changes Jun 26, 2020
View reviewed changes
Copy link
Contributor

@jo-sm jo-sm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@axe312ger axe312ger merged commit 6c72f1f into master Jun 30, 2020
@axe312ger axe312ger deleted the fix/upgrade-dependencies branch June 30, 2020 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jo-sm jo-sm jo-sm approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fresh clone and npm install fails
2 participants
@axe312ger @jo-sm